Bug 1464102 - Change the todos in browser_siteData.js to is() now that todo is working and the conditions are passing. r?johannh draft
authorJared Wein <jwein@mozilla.com>
Fri, 25 May 2018 13:28:52 -0400
changeset 799963 53dcd89f77e99819ba44c006089bff3c54a1c628
parent 799962 2ad482540f4b661f239a75ca346b265ce3fddf68
child 799964 59b3b9001569a655085e1d884e21cde5d0958099
push id111229
push userbmo:jaws@mozilla.com
push dateFri, 25 May 2018 17:33:49 +0000
reviewersjohannh
bugs1464102
milestone62.0a1
Bug 1464102 - Change the todos in browser_siteData.js to is() now that todo is working and the conditions are passing. r?johannh MozReview-Commit-ID: Ln7d9iDe8lA
browser/components/preferences/in-content/tests/siteData/browser_siteData.js
--- a/browser/components/preferences/in-content/tests/siteData/browser_siteData.js
+++ b/browser/components/preferences/in-content/tests/siteData/browser_siteData.js
@@ -175,23 +175,23 @@ add_task(async function() {
     is(siteItems.length, 2, "Should list two sites with cookies");
     let sitesList = frameDoc.getElementById("sitesList");
     let site1 = sitesList.querySelector(`richlistitem[host="example.com"]`);
     let site2 = sitesList.querySelector(`richlistitem[host="example.org"]`);
 
     let columns = site1.querySelectorAll(".item-box > label");
     is(columns[0].value, "example.com", "Should show the correct host.");
     is(columns[1].value, "2", "Should show the correct number of cookies.");
-    todo(columns[2].value == "", "Should show no site data.");
+    is(columns[2].value, "", "Should show no site data.");
     is(columns[3].value, args.creationDate1, "Should show the correct date.");
 
     columns = site2.querySelectorAll(".item-box > label");
     is(columns[0].value, "example.org", "Should show the correct host.");
     is(columns[1].value, "1", "Should show the correct number of cookies.");
-    todo(columns[2].value == "", "Should show no site data.");
+    is(columns[2].value, "", "Should show no site data.");
     is(columns[3].value, args.creationDate2, "Should show the correct date.");
 
     let removeBtn = frameDoc.getElementById("removeSelected");
     let saveBtn = frameDoc.getElementById("save");
     site2.click();
     removeBtn.doCommand();
     saveBtn.doCommand();
   });
@@ -209,17 +209,17 @@ add_task(async function() {
     let siteItems = frameDoc.getElementsByTagName("richlistitem");
     is(siteItems.length, 1, "Should list one site with cookies");
     let sitesList = frameDoc.getElementById("sitesList");
     let site1 = sitesList.querySelector(`richlistitem[host="example.com"]`);
 
     let columns = site1.querySelectorAll(".item-box > label");
     is(columns[0].value, "example.com", "Should show the correct host.");
     is(columns[1].value, "2", "Should show the correct number of cookies.");
-    todo(columns[2].value == "", "Should show no site data.");
+    is(columns[2].value, "", "Should show no site data.");
     is(columns[3].value, args.creationDate1, "Should show the correct date.");
 
     let removeBtn = frameDoc.getElementById("removeSelected");
     let saveBtn = frameDoc.getElementById("save");
     site1.click();
     removeBtn.doCommand();
     saveBtn.doCommand();
   });