Bug 1464211 - In DataTransferItemList::Remove do not throw an error if deleting nonexistent item, r=nika draft
authorAnny Gakhokidze <agakhokidze@mozilla.com>
Fri, 25 May 2018 10:43:36 -0400
changeset 800768 0a0cdffefd8ffd777ff7e1d51203a05f8b3f0a38
parent 800767 d3843ebc084061f99622b0a3fb74dccf802a9d85
push id111477
push userbmo:agakhokidze@mozilla.com
push dateTue, 29 May 2018 04:53:15 +0000
reviewersnika
bugs1464211
milestone62.0a1
Bug 1464211 - In DataTransferItemList::Remove do not throw an error if deleting nonexistent item, r=nika In the spec, https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransferitemlist-remove, DataTransferItemList::Remove does not specify that an error should be thrown if a nonexistent item is to be removed. MozReview-Commit-ID: 8HriMr6poTY
dom/events/DataTransferItemList.cpp
--- a/dom/events/DataTransferItemList.cpp
+++ b/dom/events/DataTransferItemList.cpp
@@ -87,17 +87,16 @@ DataTransferItemList::Remove(uint32_t aI
                              ErrorResult& aRv)
 {
   if (mDataTransfer->IsReadOnly()) {
     aRv.Throw(NS_ERROR_DOM_INVALID_STATE_ERR);
     return;
   }
 
   if (aIndex >= Length()) {
-    aRv.Throw(NS_ERROR_DOM_INDEX_SIZE_ERR);
     return;
   }
 
   ClearDataHelper(mItems[aIndex], aIndex, -1, aSubjectPrincipal, aRv);
 }
 
 DataTransferItem*
 DataTransferItemList::IndexedGetter(uint32_t aIndex, bool& aFound) const