Bug 1463584 - Remove invalid Assert.throws from test_empty_password. r=standard8 draft
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Tue, 22 May 2018 20:02:43 -0700
changeset 798568 8b960c418533b62fcc880d6b6b9911bf0a24fd6a
parent 798565 e886526511be83331ecdfabd962694098f54904e
push id110793
push usermozilla@noorenberghe.ca
push dateWed, 23 May 2018 03:03:04 +0000
reviewersstandard8
bugs1463584
milestone62.0a1
Bug 1463584 - Remove invalid Assert.throws from test_empty_password. r=standard8 MozReview-Commit-ID: B4AcOaKyGPo
toolkit/components/passwordmgr/test/browser/browser_notifications_2.js
--- a/toolkit/components/passwordmgr/test/browser/browser_notifications_2.js
+++ b/toolkit/components/passwordmgr/test/browser/browser_notifications_2.js
@@ -36,21 +36,16 @@ add_task(async function test_empty_passw
 
       // Synthesize input to empty the field
       passwordTextbox.focus();
       await EventUtils.synthesizeKey("KEY_ArrowRight");
       await EventUtils.synthesizeKey("KEY_Backspace");
 
       let mainActionButton = notificationElement.button;
       Assert.ok(mainActionButton.disabled, "Main action button is disabled");
-
-      // Makes sure submiting an empty password throws an error
-      Assert.throws(notificationElement.button.doCommand(),
-                    "Can't add a login with a null or empty password.",
-                    "Should fail for an empty password");
     });
 });
 
 /**
  * Test that the doorhanger password field shows plain or * text
  * when the checkbox is checked.
  */
 add_task(async function test_toggle_password() {