Mercurial > mozreview > gecko / changeset / 238454588981e2c2d11ad7d44c15bad4d717fb1b
summary | shortlog | changelog | pushlog | graph | tags | bookmarks | branches | files | changeset | raw | zip | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Bug 1379431 - Keep URL bar open on arrows and click on anchor. r?mak draft
authorHarry Twyford <htwyford@mozilla.com>
Fri, 25 May 2018 09:25:55 -0400
changeset 799828 238454588981e2c2d11ad7d44c15bad4d717fb1b
parent 795256 cf3ee14023483cbbb57129479537c713e22c1980
push id111174
push userbmo:htwyford@mozilla.com
push dateFri, 25 May 2018 13:31:33 +0000
reviewersmak
bugs1379431
milestone62.0a1
Bug 1379431 - Keep URL bar open on arrows and click on anchor. r?mak MozReview-Commit-ID: 8plGtmNRTSL
browser/base/content/browser.xul file | annotate | diff | comparison | revisions
browser/base/content/urlbarBindings.xml file | annotate | diff | comparison | revisions 
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -172,16 +172,17 @@
     <!-- for url bar autocomplete -->
     <panel type="autocomplete-richlistbox"
            id="PopupAutoCompleteRichResult"
            role="group"
            noautofocus="true"
            hidden="true"
            flip="none"
            level="parent"
+           norolluponanchor="true"
            overflowpadding="15" />
 
    <!-- for date/time picker. consumeoutsideclicks is set to never, so that
         clicks on the anchored input box are never consumed. -->
     <panel id="DateTimePickerPanel"
            type="arrow"
            hidden="true"
            orient="vertical"
--- a/browser/base/content/urlbarBindings.xml
+++ b/browser/base/content/urlbarBindings.xml
@@ -253,23 +253,16 @@ file, You can obtain one at http://mozil
         ]]></body>
       </method>
 
       <method name="onKeyPress">
         <parameter name="aEvent"/>
         <parameter name="aNoDefer"/>
         <body><![CDATA[
           switch (aEvent.keyCode) {
-            case KeyEvent.DOM_VK_LEFT:
-            case KeyEvent.DOM_VK_RIGHT:
-            case KeyEvent.DOM_VK_HOME:
-              // Reset the selected index so that nsAutoCompleteController
-              // simply closes the popup without trying to fill anything.
-              this.popup.selectedIndex = -1;
-              break;
             case KeyEvent.DOM_VK_TAB:
               this.userSelectionBehavior = "tab";
               break;
             case KeyEvent.DOM_VK_UP:
             case KeyEvent.DOM_VK_DOWN:
             case KeyEvent.DOM_VK_PAGE_UP:
             case KeyEvent.DOM_VK_PAGE_DOWN:
               if (this.userSelectionBehavior != "tab")
gecko
Deployed from 4e825768105f at 2024-04-08T16:23:59Z.