Bug 1460509 - part 84: Make HTMLEditRules::GetNodesFromPoint() use IgnoredErrorResult instead of ErrorResult r?m_kato draft
authorMasayuki Nakano <masayuki@d-toybox.com>
Tue, 22 May 2018 23:22:27 +0900
changeset 798802 7139ea7fac9d4bae7e8342e51cb7490855aa9a77
parent 798801 6bb7d22f611594454450aab5317d4fcba1383705
child 798807 1f34ee8a19bf3ce4c1c15c246ea20831fab540b0
push id110840
push usermasayuki@d-toybox.com
push dateWed, 23 May 2018 13:41:58 +0000
reviewersm_kato
bugs1460509
milestone62.0a1
Bug 1460509 - part 84: Make HTMLEditRules::GetNodesFromPoint() use IgnoredErrorResult instead of ErrorResult r?m_kato HTMLEditRules::GetNodesFromPoint() uses ErrorResult only for checking in debug build. So, it should use IgnoredErrorResult instead. MozReview-Commit-ID: 5roQI03A0kF
editor/libeditor/HTMLEditRules.cpp
--- a/editor/libeditor/HTMLEditRules.cpp
+++ b/editor/libeditor/HTMLEditRules.cpp
@@ -7968,21 +7968,21 @@ HTMLEditRules::GetNodesFromPoint(
                  EditAction aOperation,
                  nsTArray<OwningNonNull<nsINode>>& outArrayOfNodes,
                  TouchContent aTouchContent)
 {
   if (NS_WARN_IF(!aPoint.IsSet())) {
     return NS_ERROR_INVALID_ARG;
   }
   RefPtr<nsRange> range = new nsRange(aPoint.GetContainer());
-  ErrorResult error;
-  range->SetStart(aPoint, error);
+  IgnoredErrorResult ignoredError;
+  range->SetStart(aPoint, ignoredError);
   // error will assert on failure, because we are not cleaning it up,
   // but we're asserting in that case anyway.
-  MOZ_ASSERT(!error.Failed());
+  MOZ_ASSERT(!ignoredError.Failed());
 
   // Expand the range to include adjacent inlines
   PromoteRange(*range, aOperation);
 
   // Make array of ranges
   nsTArray<RefPtr<nsRange>> arrayOfRanges;
 
   // Stuff new opRange into array