Bug 1462882 - Avoid NPE when filtering using remote-ip; r=jryans draft
authorJan Odvarko <odvarko@gmail.com>
Tue, 22 May 2018 10:34:50 +0200
changeset 797973 6cb4b7ea83e8e363a6ce635883ca39fe2e08791a
parent 797566 000309d44abb81084276c9fa977c57aee7126053
push id110654
push userjodvarko@mozilla.com
push dateTue, 22 May 2018 08:37:32 +0000
reviewersjryans
bugs1462882
milestone62.0a1
Bug 1462882 - Avoid NPE when filtering using remote-ip; r=jryans MozReview-Commit-ID: IJ2lNgMRCYz
devtools/client/netmonitor/src/utils/filter-text-utils.js
--- a/devtools/client/netmonitor/src/utils/filter-text-utils.js
+++ b/devtools/client/netmonitor/src/utils/filter-text-utils.js
@@ -123,18 +123,18 @@ function isFlagFilterMatch(item, { type,
       let protocol = item.httpVersion;
       match = typeof protocol === "string" ?
                 protocol.toLowerCase().includes(value) : false;
       break;
     case "domain":
       match = item.urlDetails.host.toLowerCase().includes(value);
       break;
     case "remote-ip":
-      match = getFormattedIPAndPort(item.remoteAddress, item.remotePort)
-        .toLowerCase().includes(value);
+      let data = getFormattedIPAndPort(item.remoteAddress, item.remotePort);
+      match = data ? data.toLowerCase().includes(value) : false;
       break;
     case "has-response-header":
       if (typeof item.responseHeaders === "object") {
         let { headers } = item.responseHeaders;
         match = headers.findIndex(h => h.name.toLowerCase() === value) > -1;
       } else {
         match = false;
       }