Bug 1463085 - Remove unnecessary self-assignment. r?maja_zf draft
authorAndreas Tolfsen <ato@sny.no>
Mon, 21 May 2018 13:29:30 +0100
changeset 797706 41126198deb32c1f64247c2e98df0e1ee4fc2731
parent 797705 dc1868d255be744a7d2d462216be205086cc60af
push id110539
push userbmo:ato@sny.no
push dateMon, 21 May 2018 12:32:22 +0000
reviewersmaja_zf
bugs1463085, 1400256
milestone62.0a1
Bug 1463085 - Remove unnecessary self-assignment. r?maja_zf Prior to bug 1400256 we used to have to deserialise the web element received from chrome space manually, and presumably this self-assignment is a leftover from that time. This fixes an eslint error upon upgrading to eslint version 5. Thanks-to: Mark Banner <standard8@mozilla.com> MozReview-Commit-ID: A46wK71AwBe
testing/marionette/listener.js
--- a/testing/marionette/listener.js
+++ b/testing/marionette/listener.js
@@ -1145,20 +1145,16 @@ function getPageSource() {
  * given search strategy.
  */
 async function findElementContent(strategy, selector, opts = {}) {
   if (!SUPPORTED_STRATEGIES.has(strategy)) {
     throw new InvalidSelectorError("Strategy not supported: " + strategy);
   }
 
   opts.all = false;
-  if (opts.startNode) {
-    opts.startNode = opts.startNode;
-  }
-
   let el = await element.find(curContainer, strategy, selector, opts);
   return seenEls.add(el);
 }
 
 /**
  * Find elements in the current browsing context's document using the
  * given search strategy.
  */