Bug 1462445 - Don't show the 3 pane inspector tooltip in the browser toolbox. r=pbro draft
authorGabriel Luong <gabriel.luong@gmail.com>
Thu, 17 May 2018 15:42:27 -0400
changeset 796573 5400c80ce3a0f4cf42f294b20994b5814f5336f1
parent 796572 cd0ebdad3e8ba6d06f62595fb0adb3c02989637a
push id110279
push userbmo:gl@mozilla.com
push dateThu, 17 May 2018 19:42:48 +0000
reviewerspbro
bugs1462445
milestone62.0a1
Bug 1462445 - Don't show the 3 pane inspector tooltip in the browser toolbox. r=pbro MozReview-Commit-ID: Ck7C6KSD2sr
devtools/client/inspector/inspector.js
--- a/devtools/client/inspector/inspector.js
+++ b/devtools/client/inspector/inspector.js
@@ -261,18 +261,19 @@ Inspector.prototype = {
       await onAllPanelsUpdated;
       await this.markup.expandNode(this.selection.nodeFront);
     }
 
     // Setup the toolbar only now because it may depend on the document.
     await this.setupToolbar();
 
     // Show the 3 pane onboarding tooltip only if the inspector is visisble since the
-    // Accessibility panel initializes the Inspector.
-    if (this.show3PaneTooltip && this.toolbox.currentToolId === "inspector") {
+    // Accessibility panel initializes the Inspector and if it is not the browser toolbox.
+    if (this.show3PaneTooltip && !this.target.chrome &&
+        this.toolbox.currentToolId === "inspector") {
       this.threePaneTooltip = new ThreePaneOnboardingTooltip(this.toolbox, this.panelDoc);
     }
 
     // Log the 3 pane inspector setting on inspector open. The question we want to answer
     // is:
     // "What proportion of users use the 3 pane vs 2 pane inspector on inspector open?"
     this.telemetry.keyedScalarAdd(THREE_PANE_ENABLED_SCALAR, this.is3PaneModeEnabled, 1);