Bug 1462272: Remove an unneeded and ugly reinterpret_cast. r?dholbert draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Wed, 16 May 2018 20:10:14 +0200
changeset 796731 da0ede9406382f3c2934756ed2569b76e866b15d
parent 796730 533ae646146375ca6f74ccdba9a93e8c68e82247
child 796732 e914cfe48f1130c295cb603d794a83f3952935f3
push id110351
push userbmo:emilio@crisal.io
push dateFri, 18 May 2018 07:45:13 +0000
reviewersdholbert
bugs1462272
milestone62.0a1
Bug 1462272: Remove an unneeded and ugly reinterpret_cast. r?dholbert MozReview-Commit-ID: Evip43nwNii
layout/generic/nsImageFrame.cpp
layout/generic/nsImageFrame.h
--- a/layout/generic/nsImageFrame.cpp
+++ b/layout/generic/nsImageFrame.cpp
@@ -209,17 +209,17 @@ nsImageFrame::DestroyFrom(nsIFrame* aDes
     if (imageLoader) {
       // Notify our image loading content that we are going away so it can
       // deregister with our refresh driver.
       imageLoader->FrameDestroyed(this);
 
       imageLoader->RemoveNativeObserver(mListener);
     }
 
-    reinterpret_cast<nsImageListener*>(mListener.get())->SetFrame(nullptr);
+    mListener->SetFrame(nullptr);
   }
 
   mListener = nullptr;
 
   // If we were displaying an icon, take ourselves off the list
   if (mDisplayingIcon)
     gIconLoad->RemoveIconObserver(this);
 
--- a/layout/generic/nsImageFrame.h
+++ b/layout/generic/nsImageFrame.h
@@ -324,17 +324,17 @@ private:
    * @param aFrameInvalidRect The area to invalidate in frame space. If null, the
    *                          entire frame will be invalidated.
    */
   void InvalidateSelf(const nsIntRect* aLayerInvalidRect,
                       const nsRect* aFrameInvalidRect);
 
   RefPtr<nsImageMap> mImageMap;
 
-  nsCOMPtr<imgINotificationObserver> mListener;
+  RefPtr<nsImageListener> mListener;
 
   nsCOMPtr<imgIContainer> mImage;
   nsCOMPtr<imgIContainer> mPrevImage;
   nsSize mComputedSize;
   mozilla::IntrinsicSize mIntrinsicSize;
   nsSize mIntrinsicRatio;
 
   bool mDisplayingIcon;