Bug 1462238: Extend/clarify expiry of accessibility instantiator/consumers telemetry. r?MarcoZ data-review=francois
1. Set A11Y_INSTANTIATORS to never expire.
2. A11Y_CONSUMERS was already set to never expire, but only because expiry was never explicitly declared (when this was allowed). Explicitly set it as never expiring now. This also means it can be removed from the associated whitelist.
3. Change the email for both so it gets to the team and me (since policy requires a responsible person and that's me now for these).
MozReview-Commit-ID: BgjMoVnVp6U
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -5,23 +5,23 @@
"kind": "flag",
"releaseChannelCollection": "opt-out",
"bug_numbers": [1382820],
"description": "Flag indicating accessibility support has been instantiated.",
"alert_emails": ["accessibility@mozilla.com"]
},
"A11Y_CONSUMERS": {
"record_in_processes": ["main"],
- "expires_in_version": "default",
+ "expires_in_version": "never",
"kind": "enumerated",
"n_values": 11,
"releaseChannelCollection": "opt-out",
- "bug_numbers": [1382820],
+ "bug_numbers": [1382820, 1462238],
"description": "A list of known accessibility clients that inject into Firefox process space (see https://dxr.mozilla.org/mozilla-central/source/accessible/windows/msaa/Compatibility.h).",
- "alert_emails": ["accessibility@mozilla.com"]
+ "alert_emails": ["accessibility@mozilla.com", "jteh@mozilla.com"]
},
"A11Y_ISIMPLEDOM_USAGE_FLAG": {
"record_in_processes": ["main"],
"expires_in_version": "default",
"kind": "flag",
"description": "Flag indicating the ISimpleDOM* accessibility interfaces has been used.",
"alert_emails": ["accessibility@mozilla.com"]
},
--- a/toolkit/components/telemetry/Scalars.yaml
+++ b/toolkit/components/telemetry/Scalars.yaml
@@ -1,23 +1,25 @@
# This file contains a definition of the scalar probes that are recorded in Telemetry.
# They are submitted with the "main" pings and can be inspected in about:telemetry.
# The following section contains the accessibility scalars.
a11y:
instantiators:
bug_numbers:
- 1323069
+ - 1462238
description: >
The leaf name and version number of the binary for the process responsible
for remotely instantiating a11y.
- expires: "61"
+ expires: never
kind: string
notification_emails:
- - dbolter@mozilla.com
+ - accessibility@mozilla.com
+ - jteh@mozilla.com
record_in_processes:
- 'main'
release_channel_collection: opt-out
keyed: false
cpp_guard: 'ACCESSIBILITY'
indicator_acted_on:
bug_numbers:
--- a/toolkit/components/telemetry/histogram-whitelists.json
+++ b/toolkit/components/telemetry/histogram-whitelists.json
@@ -1397,17 +1397,16 @@
"GFX_CRASH",
"GC_REASON_2",
"GC_MINOR_REASON",
"GC_MINOR_REASON_LONG",
"SSL_CT_POLICY_COMPLIANT_CONNECTIONS_BY_CA",
"SSL_CT_POLICY_NON_COMPLIANT_CONNECTIONS_BY_CA"
],
"expiry_default": [
- "A11Y_CONSUMERS",
"IDLE_NOTIFY_IDLE_MS",
"CACHE_MEMORY_SEARCH_2",
"OSFILE_WORKER_LAUNCH_MS",
"GEOLOCATION_OSX_SOURCE_IS_MLS",
"TRANSLATION_OPPORTUNITIES_BY_LANGUAGE",
"FX_THUMBNAILS_BG_CAPTURE_DONE_REASON_2",
"TRANSLATED_PAGES",
"FX_SESSION_RESTORE_SEND_UPDATE_CAUSED_OOM",