Bug 1462177 - Do not condition dumping of inactive layer trees on MOZ_DUMP_PAINTING. r=mstange draft
authorBotond Ballo <botond@mozilla.com>
Wed, 16 May 2018 19:02:27 -0400
changeset 796071 37f9f9893519ccc5a59d5f2ce2c4409aca89ed7a
parent 796066 945b2048b31843c27cd21c19374cb7f61ea62be5
push id110154
push userbballo@mozilla.com
push dateWed, 16 May 2018 23:03:41 +0000
reviewersmstange
bugs1462177
milestone62.0a1
Bug 1462177 - Do not condition dumping of inactive layer trees on MOZ_DUMP_PAINTING. r=mstange MozReview-Commit-ID: t38JkoVfQl
layout/painting/FrameLayerBuilder.cpp
--- a/layout/painting/FrameLayerBuilder.cpp
+++ b/layout/painting/FrameLayerBuilder.cpp
@@ -5122,24 +5122,22 @@ FrameLayerBuilder::AddPaintedDisplayItem
       DisplayItemData* data = layerBuilder->GetDisplayItemDataForManager(aItem.mItem, tempManager);
       layerBuilder->StoreDataForFrame(aItem.mItem, tmpLayer, LAYER_ACTIVE, data);
     }
 
     tempManager->SetRoot(tmpLayer);
     layerBuilder->WillEndTransaction();
     tempManager->AbortTransaction();
 
-#ifdef MOZ_DUMP_PAINTING
     if (gfxUtils::DumpDisplayList() || gfxEnv::DumpPaint()) {
       fprintf_stderr(gfxUtils::sDumpPaintFile, "Basic layer tree for painting contents of display item %s(%p):\n", aItem.mItem->Name(), aItem.mItem->Frame());
       std::stringstream stream;
       tempManager->Dump(stream, "", gfxEnv::DumpPaintToFile());
       fprint_stderr(gfxUtils::sDumpPaintFile, stream);  // not a typo, fprint_stderr declared in LayersLogging.h
     }
-#endif
 
     nsIntPoint offset = GetLastPaintOffset(layer) - GetTranslationForPaintedLayer(layer);
     props->MoveBy(-offset);
     // Effective transforms are needed by ComputeDifferences().
     tmpLayer->ComputeEffectiveTransforms(Matrix4x4());
     nsIntRegion invalid;
     if (!props->ComputeDifferences(tmpLayer, invalid, nullptr)) {
       nsRect visible = aItem.mItem->Frame()->GetVisualOverflowRect();