Bug 1454686 - Remove Lint error suppression for unused strings; r?mcomella draft
authorPetru Lingurar <petru.lingurar@softvision.ro>
Wed, 16 May 2018 15:59:56 +0300
changeset 796364 519ed4003be448d60e719c13c40dfcb1adbb30c7
parent 796363 931172a14560c053eb2d36743d90da6decc28912
push id110233
push userplingurar@mozilla.com
push dateThu, 17 May 2018 16:13:02 +0000
reviewersmcomella
bugs1454686, 1445798
milestone62.0a1
Bug 1454686 - Remove Lint error suppression for unused strings; r?mcomella Strings needed for this feature were added in a separate bug - 1445798 which were causing Lint errors. When this feature will land there will be no need for the suppression. MozReview-Commit-ID: IhtTS8rHLwz
mobile/android/app/lint.xml
--- a/mobile/android/app/lint.xml
+++ b/mobile/android/app/lint.xml
@@ -236,19 +236,16 @@
     <issue id="UnlocalizedSms" severity="error" />
     <issue id="UnusedNamespace" severity="error" />
     <issue id="UnusedQuantity" severity="error" />
     <issue id="UnusedResources" severity="error">
         <!-- The moz.build based build system leaves a .mkdir.done file lying around in the
              preprocessed_resources res/raw folder. Lint reports it as unused. We should get
              rid of the file eventually. See bug 1268948. -->
         <ignore path="**/raw/.mkdir.done" />
-        <!-- Needed to ignore currently unused resources added as per bug 1445798
-             Suppression to be removed when the along with the ptch for bug 1454686 -->
-        <ignore path="**/res/values/strings.xml" />
     </issue>
     <issue id="Usability" severity="error" />
     <issue id="UseCheckPermission" severity="error" />
     <issue id="UseCompoundDrawables" severity="error" />
     <issue id="UselessLeaf" severity="error" />
     <issue id="UsesMinSdkAttributes" severity="error" />
     <issue id="UsingHttp" severity="error" />
     <issue id="ViewHolder" severity="error" />