--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-createOffer.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-createOffer.html
@@ -11,17 +11,17 @@
// https://w3c.github.io/webrtc-pc/archives/20170515/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
// generateOffer()
// generateAnswer()
// countAudioLine()
// countVideoLine()
// test_state_change_event()
- // assert_session_desc_equals()
+ // assert_session_desc_similar()
/*
* 4.3.2. createOffer()
*/
/*
* Final steps to create an offer
* 4. Let offer be a newly created RTCSessionDescriptionInit dictionary
@@ -45,18 +45,18 @@
const pc = new RTCPeerConnection();
test_state_change_event(t, pc, ['have-local-offer']);
return pc.createOffer({ offerToReceiveAudio: true })
.then(offer =>
pc.setLocalDescription(offer)
.then(() => {
assert_equals(pc.signalingState, 'have-local-offer');
- assert_session_desc_equals(pc.localDescription, offer);
- assert_session_desc_equals(pc.pendingLocalDescription, offer);
+ assert_session_desc_similar(pc.localDescription, offer);
+ assert_session_desc_similar(pc.pendingLocalDescription, offer);
assert_equals(pc.currentLocalDescription, null);
}));
}, 'createOffer() and then setLocalDescription() should succeed');
promise_test(t => {
const pc = new RTCPeerConnection();
pc.close();
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-helper.js
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-helper.js
@@ -88,22 +88,22 @@ function isSimilarSessionDescription(ses
if(sessionDesc1.type !== sessionDesc2.type) {
return false;
} else {
return similarMediaDescriptions(sessionDesc1.sdp, sessionDesc2.sdp);
}
}
-function assert_session_desc_equals(sessionDesc1, sessionDesc2) {
+function assert_session_desc_similar(sessionDesc1, sessionDesc2) {
assert_true(isSimilarSessionDescription(sessionDesc1, sessionDesc2),
'Expect both session descriptions to have the same count of media lines');
}
-function assert_session_desc_not_equals(sessionDesc1, sessionDesc2) {
+function assert_session_desc_not_similar(sessionDesc1, sessionDesc2) {
assert_false(isSimilarSessionDescription(sessionDesc1, sessionDesc2),
'Expect both session descriptions to have different count of media lines');
}
// Helper function to generate offer using a freshly created RTCPeerConnection
// object with any audio, video, data media lines present
function generateOffer(options={}) {
const {
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-answer.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-answer.html
@@ -8,17 +8,17 @@
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
// generateOffer
// generateAnswer
- // assert_session_desc_equals
+ // assert_session_desc_similar
// test_state_change_event
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setRemoteDescription(
RTCSessionDescriptionInit description);
@@ -66,21 +66,21 @@
return pc.createOffer({ offerToReceiveVideo: true })
.then(offer =>
pc.setRemoteDescription(offer)
.then(() => pc.createAnswer())
.then(answer =>
pc.setLocalDescription(answer)
.then(() => {
assert_equals(pc.signalingState, 'stable');
- assert_session_desc_equals(pc.localDescription, answer);
- assert_session_desc_equals(pc.remoteDescription, offer);
+ assert_session_desc_similar(pc.localDescription, answer);
+ assert_session_desc_similar(pc.remoteDescription, offer);
- assert_session_desc_equals(pc.currentLocalDescription, answer);
- assert_session_desc_equals(pc.currentRemoteDescription, offer);
+ assert_session_desc_similar(pc.currentLocalDescription, answer);
+ assert_session_desc_similar(pc.currentRemoteDescription, offer);
assert_equals(pc.pendingLocalDescription, null);
assert_equals(pc.pendingRemoteDescription, null);
})));
}, 'setLocalDescription() with valid answer should succeed');
/*
4.3.2. setLocalDescription
@@ -94,21 +94,21 @@
return pc.createOffer({ offerToReceiveVideo: true })
.then(offer =>
pc.setRemoteDescription(offer)
.then(() => pc.createAnswer())
.then(answer =>
pc.setLocalDescription({ type: 'answer' })
.then(() => {
assert_equals(pc.signalingState, 'stable');
- assert_session_desc_equals(pc.localDescription, answer);
- assert_session_desc_equals(pc.remoteDescription, offer);
+ assert_session_desc_similar(pc.localDescription, answer);
+ assert_session_desc_similar(pc.remoteDescription, offer);
- assert_session_desc_equals(pc.currentLocalDescription, answer);
- assert_session_desc_equals(pc.currentRemoteDescription, offer);
+ assert_session_desc_similar(pc.currentLocalDescription, answer);
+ assert_session_desc_similar(pc.currentRemoteDescription, offer);
assert_equals(pc.pendingLocalDescription, null);
assert_equals(pc.pendingRemoteDescription, null);
})));
}, 'setLocalDescription() with type answer and null sdp should use lastAnswer generated from createAnswer');
/*
4.3.2. setLocalDescription
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html
@@ -7,18 +7,18 @@
<script>
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
// generateOffer
- // assert_session_desc_not_equals
- // assert_session_desc_equals
+ // assert_session_desc_not_similar
+ // assert_session_desc_similar
// test_state_change_event
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setRemoteDescription(
RTCSessionDescriptionInit description);
@@ -60,18 +60,18 @@
const pc = new RTCPeerConnection();
test_state_change_event(t, pc, ['have-local-offer']);
return pc.createOffer({ offerToReceiveAudio: true })
.then(offer =>
pc.setLocalDescription(offer)
.then(() => {
assert_equals(pc.signalingState, 'have-local-offer');
- assert_session_desc_equals(pc.localDescription, offer);
- assert_session_desc_equals(pc.pendingLocalDescription, offer);
+ assert_session_desc_similar(pc.localDescription, offer);
+ assert_session_desc_similar(pc.pendingLocalDescription, offer);
assert_equals(pc.currentLocalDescription, null);
}));
}, 'setLocalDescription with valid offer should succeed');
/*
4.3.2. setLocalDescription
2. Let lastOffer be the result returned by the last call to createOffer.
5. If description.sdp is null and description.type is offer, set description.sdp
@@ -79,18 +79,18 @@
*/
promise_test(t => {
const pc = new RTCPeerConnection();
return pc.createOffer({ offerToReceiveAudio: true })
.then(offer =>
pc.setLocalDescription({ type: 'offer' })
.then(() => {
assert_equals(pc.signalingState, 'have-local-offer');
- assert_session_desc_equals(pc.localDescription, offer);
- assert_session_desc_equals(pc.pendingLocalDescription, offer);
+ assert_session_desc_similar(pc.localDescription, offer);
+ assert_session_desc_similar(pc.pendingLocalDescription, offer);
assert_equals(pc.currentLocalDescription, null);
}));
}, 'setLocalDescription with type offer and null sdp should use lastOffer generated from createOffer');
/*
4.3.2. setLocalDescription
2. Let lastOffer be the result returned by the last call to createOffer.
6. If description.type is offer and description.sdp does not match lastOffer,
@@ -112,17 +112,17 @@
// both audio and video line. Since the second offer is the
// last offer, setLocalDescription would reject when setting
// with the first offer
const pc = new RTCPeerConnection();
return pc.createOffer({ offerToReceiveAudio: true })
.then(offer1 =>
pc.createOffer({ offerToReceiveVideo: true })
.then(offer2 => {
- assert_session_desc_not_equals(offer1, offer2);
+ assert_session_desc_not_similar(offer1, offer2);
return promise_rejects(t, 'InvalidModificationError',
pc.setLocalDescription(offer1));
}));
}, 'Set created offer other than last offer should reject with InvalidModificationError');
promise_test(t => {
const pc = new RTCPeerConnection();
@@ -132,17 +132,17 @@
return pc.createOffer({ offerToReceiveAudio: true })
.then(offer1 =>
pc.setLocalDescription(offer1)
.then(() =>
pc.createOffer({ offerToReceiveVideo: true })
.then(offer2 =>
pc.setLocalDescription(offer2)
.then(offer2 => {
- assert_session_desc_not_equals(offer1, offer2);
+ assert_session_desc_not_similar(offer1, offer2);
assert_equals(pc.signalingState, 'have-local-offer');
- assert_session_desc_equals(pc.localDescription, offer2);
- assert_session_desc_equals(pc.pendingLocalDescription, offer2);
+ assert_session_desc_similar(pc.localDescription, offer2);
+ assert_session_desc_similar(pc.pendingLocalDescription, offer2);
assert_equals(pc.currentLocalDescription, null);
}))));
}, 'Creating and setting offer multiple times should succeed');
</script>
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-pranswer.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-pranswer.html
@@ -8,17 +8,17 @@
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
// generateOffer
// generateAnswer
- // assert_session_desc_equals
+ // assert_session_desc_similar
// test_state_change_event
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setLocalDescription(
RTCSessionDescriptionInit description);
@@ -89,22 +89,22 @@
.then(() => pc.createAnswer())
.then(answer => {
const pranswer = { type: 'pranswer', sdp: answer.sdp };
return pc.setLocalDescription(pranswer)
.then(() => {
assert_equals(pc.signalingState, 'have-local-pranswer');
- assert_session_desc_equals(pc.remoteDescription, offer);
- assert_session_desc_equals(pc.pendingRemoteDescription, offer);
+ assert_session_desc_similar(pc.remoteDescription, offer);
+ assert_session_desc_similar(pc.pendingRemoteDescription, offer);
assert_equals(pc.currentRemoteDescription, null);
- assert_session_desc_equals(pc.localDescription, pranswer);
- assert_session_desc_equals(pc.pendingLocalDescription, pranswer);
+ assert_session_desc_similar(pc.localDescription, pranswer);
+ assert_session_desc_similar(pc.pendingLocalDescription, pranswer);
assert_equals(pc.currentLocalDescription, null);
assert_equals(pc.pendingRemoteDescription, null);
});
}));
}, 'setLocalDescription(pranswer) should succeed');
promise_test(t => {
@@ -133,21 +133,21 @@
.then(() => pc.createAnswer())
.then(answer => {
const pranswer = { type: 'pranswer', sdp: answer.sdp };
return pc.setLocalDescription(pranswer)
.then(() => pc.setLocalDescription(answer))
.then(() => {
assert_equals(pc.signalingState, 'stable');
- assert_session_desc_equals(pc.localDescription, answer);
- assert_session_desc_equals(pc.remoteDescription, offer);
+ assert_session_desc_similar(pc.localDescription, answer);
+ assert_session_desc_similar(pc.remoteDescription, offer);
- assert_session_desc_equals(pc.currentLocalDescription, answer);
- assert_session_desc_equals(pc.currentRemoteDescription, offer);
+ assert_session_desc_similar(pc.currentLocalDescription, answer);
+ assert_session_desc_similar(pc.currentRemoteDescription, offer);
assert_equals(pc.pendingLocalDescription, null);
assert_equals(pc.pendingRemoteDescription, null);
});
}));
}, 'setLocalDescription(answer) from have-local-pranswer state should succeed');
</script>
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-rollback.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-rollback.html
@@ -6,17 +6,17 @@
<script src="RTCPeerConnection-helper.js"></script>
<script>
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
- // assert_session_desc_equals
+ // assert_session_desc_similar
// test_state_change_event
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setLocalDescription(
RTCSessionDescriptionInit description);
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription.html
@@ -7,18 +7,18 @@
<script>
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
// generateOffer
- // assert_session_desc_not_equals
- // assert_session_desc_equals
+ // assert_session_desc_not_similar
+ // assert_session_desc_similar
// test_state_change_event
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setRemoteDescription(
RTCSessionDescriptionInit description);
@@ -56,20 +56,20 @@
.then(() => {
pc.createDataChannel('test');
return pc.createOffer({ offerToReceiveVideo: true });
})
.then(offer2 =>
pc.setLocalDescription(offer2)
.then(() => {
assert_equals(pc.signalingState, 'have-local-offer');
- assert_session_desc_not_equals(offer1, offer2);
- assert_session_desc_equals(pc.localDescription, offer2);
- assert_session_desc_equals(pc.currentLocalDescription, offer1);
- assert_session_desc_equals(pc.pendingLocalDescription, offer2);
+ assert_session_desc_not_similar(offer1, offer2);
+ assert_session_desc_similar(pc.localDescription, offer2);
+ assert_session_desc_similar(pc.currentLocalDescription, offer1);
+ assert_session_desc_similar(pc.pendingLocalDescription, offer2);
})));
}, 'Calling createOffer() and setLocalDescription() again after one round of local-offer/remote-answer should succeed');
promise_test(t => {
const pc = new RTCPeerConnection();
test_state_change_event(t, pc,
['have-remote-offer', 'stable', 'have-local-offer']);
@@ -78,19 +78,19 @@
.then(() => pc.createAnswer())
.then(answer =>
pc.setLocalDescription(answer)
.then(() => pc.createOffer({ offerToReceiveVideo: true }))
.then(offer =>
pc.setLocalDescription(offer)
.then(() => {
assert_equals(pc.signalingState, 'have-local-offer');
- assert_session_desc_equals(pc.localDescription, offer);
- assert_session_desc_equals(pc.currentLocalDescription, answer);
- assert_session_desc_equals(pc.pendingLocalDescription, offer);
+ assert_session_desc_similar(pc.localDescription, offer);
+ assert_session_desc_similar(pc.currentLocalDescription, answer);
+ assert_session_desc_similar(pc.pendingLocalDescription, offer);
})));
}, 'Switching role from answerer to offerer after going back to stable state should succeed');
/*
TODO
4.3.2. setLocalDescription
4. If description.sdp is null and description.type is pranswer, set description.sdp
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-setRemoteDescription-answer.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-setRemoteDescription-answer.html
@@ -8,17 +8,17 @@
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
// generateOffer()
// generateAnswer()
- // assert_session_desc_equals()
+ // assert_session_desc_similar()
// test_state_change_event()
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setRemoteDescription(
RTCSessionDescriptionInit description);
@@ -66,21 +66,21 @@
.then(offer =>
pc.setLocalDescription(offer)
.then(() => generateAnswer(offer))
.then(answer =>
pc.setRemoteDescription(answer)
.then(() => {
assert_equals(pc.signalingState, 'stable');
- assert_session_desc_equals(pc.localDescription, offer);
- assert_session_desc_equals(pc.remoteDescription, answer);
+ assert_session_desc_similar(pc.localDescription, offer);
+ assert_session_desc_similar(pc.remoteDescription, answer);
- assert_session_desc_equals(pc.currentLocalDescription, offer);
- assert_session_desc_equals(pc.currentRemoteDescription, answer);
+ assert_session_desc_similar(pc.currentLocalDescription, offer);
+ assert_session_desc_similar(pc.currentRemoteDescription, answer);
assert_equals(pc.pendingLocalDescription, null);
assert_equals(pc.pendingRemoteDescription, null);
})));
}, 'setRemoteDescription() with valid state and answer should succeed');
/*
4.3.1.6. Set the RTCSessionSessionDescription
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-setRemoteDescription-offer.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-setRemoteDescription-offer.html
@@ -6,17 +6,17 @@
<script src="RTCPeerConnection-helper.js"></script>
<script>
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
- // assert_session_desc_equals()
+ // assert_session_desc_similar()
// test_state_change_event()
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setRemoteDescription(
RTCSessionDescriptionInit description);
@@ -58,18 +58,18 @@
test_state_change_event(t, pc2, ['have-remote-offer']);
return pc1.createOffer()
.then(offer => {
return pc2.setRemoteDescription(offer)
.then(() => {
assert_equals(pc2.signalingState, 'have-remote-offer');
- assert_session_desc_equals(pc2.remoteDescription, offer);
- assert_session_desc_equals(pc2.pendingRemoteDescription, offer);
+ assert_session_desc_similar(pc2.remoteDescription, offer);
+ assert_session_desc_similar(pc2.pendingRemoteDescription, offer);
assert_equals(pc2.currentRemoteDescription, null);
});
});
}, 'setRemoteDescription with valid offer should succeed');
promise_test(t => {
const pc1 = new RTCPeerConnection();
pc1.createDataChannel('datachannel');
@@ -80,18 +80,18 @@
test_state_change_event(t, pc2, ['have-remote-offer']);
return pc1.createOffer()
.then(offer => {
return pc2.setRemoteDescription(offer)
.then(() => pc2.setRemoteDescription(offer))
.then(() => {
assert_equals(pc2.signalingState, 'have-remote-offer');
- assert_session_desc_equals(pc2.remoteDescription, offer);
- assert_session_desc_equals(pc2.pendingRemoteDescription, offer);
+ assert_session_desc_similar(pc2.remoteDescription, offer);
+ assert_session_desc_similar(pc2.pendingRemoteDescription, offer);
assert_equals(pc2.currentRemoteDescription, null);
});
});
}, 'setRemoteDescription multiple times should succeed');
promise_test(t => {
const pc1 = new RTCPeerConnection();
pc1.createDataChannel('datachannel');
@@ -102,24 +102,24 @@
test_state_change_event(t, pc2, ['have-remote-offer']);
return pc1.createOffer()
.then(offer1 => {
return pc1.setLocalDescription(offer1)
.then(()=> {
return pc1.createOffer({ offerToReceiveAudio: true })
.then(offer2 => {
- assert_session_desc_not_equals(offer1, offer2);
+ assert_session_desc_not_similar(offer1, offer2);
return pc2.setRemoteDescription(offer1)
.then(() => pc2.setRemoteDescription(offer2))
.then(() => {
assert_equals(pc2.signalingState, 'have-remote-offer');
- assert_session_desc_equals(pc2.remoteDescription, offer2);
- assert_session_desc_equals(pc2.pendingRemoteDescription, offer2);
+ assert_session_desc_similar(pc2.remoteDescription, offer2);
+ assert_session_desc_similar(pc2.pendingRemoteDescription, offer2);
assert_equals(pc2.currentRemoteDescription, null);
});
});
});
});
}, 'setRemoteDescription multiple times with different offer should succeed');
/*
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-setRemoteDescription-pranswer.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-setRemoteDescription-pranswer.html
@@ -8,17 +8,17 @@
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
// generateOffer
// generateAnswer
- // assert_session_desc_equals
+ // assert_session_desc_similar
// test_state_change_event
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setLocalDescription(
RTCSessionDescriptionInit description);
@@ -88,22 +88,22 @@
.then(() => generateAnswer(offer))
.then(answer => {
const pranswer = { type: 'pranswer', sdp: answer.sdp };
return pc.setRemoteDescription(pranswer)
.then(() => {
assert_equals(pc.signalingState, 'have-remote-pranswer');
- assert_session_desc_equals(pc.localDescription, offer);
- assert_session_desc_equals(pc.pendingLocalDescription, offer);
+ assert_session_desc_similar(pc.localDescription, offer);
+ assert_session_desc_similar(pc.pendingLocalDescription, offer);
assert_equals(pc.currentLocalDescription, null);
- assert_session_desc_equals(pc.remoteDescription, pranswer);
- assert_session_desc_equals(pc.pendingRemoteDescription, pranswer);
+ assert_session_desc_similar(pc.remoteDescription, pranswer);
+ assert_session_desc_similar(pc.pendingRemoteDescription, pranswer);
assert_equals(pc.currentRemoteDescription, null);
});
}));
}, 'setRemoteDescription(pranswer) from have-local-offer state should succeed');
promise_test(t => {
const pc = new RTCPeerConnection();
test_state_change_event(t, pc, ['have-local-offer', 'have-remote-pranswer']);
@@ -131,20 +131,20 @@
.then(answer => {
const pranswer = { type: 'pranswer', sdp: answer.sdp };
return pc.setRemoteDescription(pranswer)
.then(() => pc.setRemoteDescription(answer))
.then(() => {
assert_equals(pc.signalingState, 'stable');
- assert_session_desc_equals(pc.localDescription, offer);
- assert_session_desc_equals(pc.currentLocalDescription, offer);
+ assert_session_desc_similar(pc.localDescription, offer);
+ assert_session_desc_similar(pc.currentLocalDescription, offer);
assert_equals(pc.pendingLocalDescription, null);
- assert_session_desc_equals(pc.remoteDescription, answer);
- assert_session_desc_equals(pc.currentRemoteDescription, answer);
+ assert_session_desc_similar(pc.remoteDescription, answer);
+ assert_session_desc_similar(pc.currentRemoteDescription, answer);
assert_equals(pc.pendingRemoteDescription, null);
});
}));
}, 'setRemoteDescription(answer) from have-remote-pranswer state should succeed');
</script>
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-setRemoteDescription-rollback.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-setRemoteDescription-rollback.html
@@ -7,17 +7,17 @@
<script>
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
// generateOffer
- // assert_session_desc_equals
+ // assert_session_desc_similar
// test_state_change_event
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setLocalDescription(
RTCSessionDescriptionInit description);
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-setRemoteDescription.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-setRemoteDescription.html
@@ -6,18 +6,18 @@
<script src="RTCPeerConnection-helper.js"></script>
<script>
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
- // assert_session_desc_not_equals()
- // assert_session_desc_equals()
+ // assert_session_desc_not_similar()
+ // assert_session_desc_similar()
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setRemoteDescription(
RTCSessionDescriptionInit description);
@@ -113,38 +113,38 @@
t.add_cleanup(() => pc.close());
t.add_cleanup(() => pc2.close());
const offer1 = await pc2.createOffer({ offerToReceiveAudio: true });
await pc.setRemoteDescription(offer1);
await pc.setLocalDescription(await pc.createAnswer());
const offer2 = await pc2.createOffer({ offerToReceiveVideo: true });
await pc.setRemoteDescription(offer2);
- assert_session_desc_not_equals(offer1, offer2);
- assert_session_desc_equals(pc.remoteDescription, offer2);
- assert_session_desc_equals(pc.currentRemoteDescription, offer1);
- assert_session_desc_equals(pc.pendingRemoteDescription, offer2);
+ assert_session_desc_not_similar(offer1, offer2);
+ assert_session_desc_similar(pc.remoteDescription, offer2);
+ assert_session_desc_similar(pc.currentRemoteDescription, offer1);
+ assert_session_desc_similar(pc.pendingRemoteDescription, offer2);
}, 'Calling setRemoteDescription() again after one round of remote-offer/local-answer should succeed');
promise_test(async t => {
const pc = new RTCPeerConnection();
const pc2 = new RTCPeerConnection();
t.add_cleanup(() => pc.close());
t.add_cleanup(() => pc2.close());
const offer = await pc.createOffer({ offerToReceiveAudio: true });
await pc.setLocalDescription(offer);
await pc2.setRemoteDescription(offer);
const answer = await pc2.createAnswer();
await pc2.setLocalDescription(answer);
await pc.setRemoteDescription(answer);
await pc.setRemoteDescription(await pc2.createOffer());
assert_equals(pc.remoteDescription.sdp, pc.pendingRemoteDescription.sdp);
- assert_session_desc_equals(pc.remoteDescription, offer);
- assert_session_desc_equals(pc.currentRemoteDescription, answer);
+ assert_session_desc_similar(pc.remoteDescription, offer);
+ assert_session_desc_similar(pc.currentRemoteDescription, answer);
}, 'Switching role from offerer to answerer after going back to stable state should succeed');
/*
TODO
4.3.2. setRemoteDescription
- If an a=identity attribute is present in the session description, the browser
validates the identity assertion.
*/