Bug 1451005 - Add telemetry probes for low commit-space events; r?chutten
MozReview-Commit-ID: 9sFnmc9ku8u
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -1072,44 +1072,47 @@
"alert_emails": ["memshrink-telemetry-alerts@mozilla.com"],
"expires_in_version": "never",
"kind": "exponential",
"high": 1024,
"n_buckets": 10,
"description": "Time(ms) to purge dirty heap pages."
},
"LOW_MEMORY_EVENTS_VIRTUAL": {
- "record_in_processes": ["main", "content"],
+ "record_in_processes": ["main"],
"alert_emails": ["memshrink-telemetry-alerts@mozilla.com"],
"expires_in_version": "never",
"kind": "exponential",
"high": 1024,
"n_buckets": 21,
"description": "Number of low-virtual-memory events fired since last ping",
- "cpp_guard": "XP_WIN"
+ "cpp_guard": "XP_WIN",
+ "bug_numbers": [711490,1451005]
},
"LOW_MEMORY_EVENTS_PHYSICAL": {
- "record_in_processes": ["main", "content"],
+ "record_in_processes": ["main"],
"alert_emails": ["memshrink-telemetry-alerts@mozilla.com"],
"expires_in_version": "never",
"kind": "exponential",
"high": 1024,
"n_buckets": 21,
"description": "Number of low-physical-memory events fired since last ping",
- "cpp_guard": "XP_WIN"
+ "cpp_guard": "XP_WIN",
+ "bug_numbers": [711490,1451005]
},
"LOW_MEMORY_EVENTS_COMMIT_SPACE": {
- "record_in_processes": ["main", "content"],
+ "record_in_processes": ["main"],
"alert_emails": ["memshrink-telemetry-alerts@mozilla.com"],
"expires_in_version": "never",
"kind": "exponential",
"high": 1024,
"n_buckets": 21,
"description": "Number of low-commit-space events fired since last ping",
- "cpp_guard": "XP_WIN"
+ "cpp_guard": "XP_WIN",
+ "bug_numbers": [1451005]
},
"PAGE_FAULTS_HARD": {
"record_in_processes": ["main", "content"],
"expires_in_version": "default",
"kind": "exponential",
"low": 8,
"high": 65536,
"n_buckets": 13,
--- a/toolkit/components/telemetry/TelemetrySession.jsm
+++ b/toolkit/components/telemetry/TelemetrySession.jsm
@@ -1089,16 +1089,17 @@ var Impl = {
b("MEMORY_UNIQUE", "residentUnique");
p("MEMORY_HEAP_OVERHEAD_FRACTION", "heapOverheadFraction");
b("MEMORY_JS_GC_HEAP", "JSMainRuntimeGCHeap");
c("MEMORY_JS_COMPARTMENTS_SYSTEM", "JSMainRuntimeCompartmentsSystem");
c("MEMORY_JS_COMPARTMENTS_USER", "JSMainRuntimeCompartmentsUser");
b("MEMORY_IMAGES_CONTENT_USED_UNCOMPRESSED", "imagesContentUsedUncompressed");
b("MEMORY_STORAGE_SQLITE", "storageSQLite");
cc("LOW_MEMORY_EVENTS_VIRTUAL", "lowMemoryEventsVirtual");
+ cc("LOW_MEMORY_EVENTS_COMMIT_SPACE", "lowMemoryEventsCommitSpace");
cc("LOW_MEMORY_EVENTS_PHYSICAL", "lowMemoryEventsPhysical");
cc("PAGE_FAULTS_HARD", "pageFaultsHard");
try {
mgr.getHeapAllocatedAsync(heapAllocated => {
boundHandleMemoryReport("MEMORY_HEAP_ALLOCATED",
Ci.nsIMemoryReporter.UNITS_BYTES,
heapAllocated);
--- a/toolkit/components/telemetry/histogram-whitelists.json
+++ b/toolkit/components/telemetry/histogram-whitelists.json
@@ -840,19 +840,16 @@
"LOCALDOMSTORAGE_GETVALUE_BLOCKING_MS",
"LOCALDOMSTORAGE_PRELOAD_PENDING_ON_FIRST_ACCESS",
"LOCALDOMSTORAGE_REMOVEKEY_BLOCKING_MS",
"LOCALDOMSTORAGE_SESSIONONLY_PRELOAD_BLOCKING_MS",
"LOCALDOMSTORAGE_SETVALUE_BLOCKING_MS",
"LOCALDOMSTORAGE_SHUTDOWN_DATABASE_MS",
"LOCALDOMSTORAGE_UNLOAD_BLOCKING_MS",
"LONG_REFLOW_INTERRUPTIBLE",
- "LOW_MEMORY_EVENTS_COMMIT_SPACE",
- "LOW_MEMORY_EVENTS_PHYSICAL",
- "LOW_MEMORY_EVENTS_VIRTUAL",
"MAC_INITFONTLIST_TOTAL",
"MASTER_PASSWORD_ENABLED",
"MEDIA_CODEC_USED",
"MEDIA_WMF_DECODE_ERROR",
"MEMORY_FREE_PURGED_PAGES_MS",
"MEMORY_HEAP_ALLOCATED",
"MEMORY_IMAGES_CONTENT_USED_UNCOMPRESSED",
"MEMORY_JS_COMPARTMENTS_SYSTEM",