Bug 1461023 - Disable the assertion that checks the previous opacity animation value exists when we skip computing opacity animation. r?kats draft
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Sat, 12 May 2018 08:01:46 +0900
changeset 794389 68815073f5c7943b9d137df7a70a7e9b543de9ea
parent 794135 21f09d7e7214eaebf1e0980494159bd846e1bdd9
push id109678
push userhikezoe@mozilla.com
push dateFri, 11 May 2018 23:02:02 +0000
reviewerskats
bugs1461023, 1459775
milestone62.0a1
Bug 1461023 - Disable the assertion that checks the previous opacity animation value exists when we skip computing opacity animation. r?kats We are going to re-enable the assertion with a proper fix in bug 1459775. MozReview-Commit-ID: 2jy6vIImqD
gfx/layers/composite/AsyncCompositionManager.cpp
--- a/gfx/layers/composite/AsyncCompositionManager.cpp
+++ b/gfx/layers/composite/AsyncCompositionManager.cpp
@@ -712,19 +712,21 @@ SampleAnimations(Layer* aLayer,
             // We don't need to update animation values for this layer since
             // the values haven't changed.
 #ifdef DEBUG
             // Sanity check that the animation value is surely unchanged.
             switch (animations[0].property()) {
               case eCSSProperty_opacity:
                 MOZ_ASSERT(
                   layer->AsHostLayer()->GetShadowOpacitySetByAnimation());
-                MOZ_ASSERT(FuzzyEqualsMultiplicative(
-                  Servo_AnimationValue_GetOpacity(animationValue),
-                  *(aStorage->GetAnimationOpacity(layer->GetCompositorAnimationsId()))));
+                // Disable this assertion until the root cause is fixed in bug
+                // 1459775.
+                // MOZ_ASSERT(FuzzyEqualsMultiplicative(
+                //   Servo_AnimationValue_GetOpacity(animationValue),
+                //   *(aStorage->GetAnimationOpacity(layer->GetCompositorAnimationsId()))));
                 break;
               case eCSSProperty_transform: {
                 MOZ_ASSERT(
                   layer->AsHostLayer()->GetShadowTransformSetByAnimation());
 
                 MOZ_ASSERT(previousValue);
 
                 const TransformData& transformData =