Bug 1460059 - [wdspec] Remove superfluous set_window_rect/resizing_and_positioning.py. draft
authorHenrik Skupin <mail@hskupin.info>
Fri, 11 May 2018 15:23:59 +0200
changeset 794180 ee2def8e2ff720f9195bbd412ef4489b1010070d
parent 793719 17db33b6a124422d43a9f518bea1bc62a698126b
push id109594
push userbmo:hskupin@gmail.com
push dateFri, 11 May 2018 13:24:36 +0000
bugs1460059
milestone62.0a1
Bug 1460059 - [wdspec] Remove superfluous set_window_rect/resizing_and_positioning.py. MozReview-Commit-ID: 4cEvbPM3Wlm
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/webdriver/tests/set_window_rect/resizing_and_positioning.py
testing/web-platform/tests/webdriver/tests/set_window_rect/set.py
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -397619,22 +397619,16 @@
     ]
    ],
    "webdriver/tests/send_alert_text/send.py": [
     [
      "/webdriver/tests/send_alert_text/send.py",
      {}
     ]
    ],
-   "webdriver/tests/set_window_rect/resizing_and_positioning.py": [
-    [
-     "/webdriver/tests/set_window_rect/resizing_and_positioning.py",
-     {}
-    ]
-   ],
    "webdriver/tests/set_window_rect/set.py": [
     [
      "/webdriver/tests/set_window_rect/set.py",
      {
       "timeout": "long"
      }
     ]
    ],
@@ -515403,17 +515397,17 @@
    "27d36ba54623bbee2cdd09b7a9322873d5ab0011",
    "reftest"
   ],
   "css/css-scoping/stylesheet-title-001.html": [
    "2e49b6d74d2021144444ca77e62acbc6aeffac2a",
    "reftest"
   ],
   "css/css-scoping/stylesheet-title-002.html": [
-   "9e228381a0aa11c76568b8ec893ed6745581bbf9",
+   "5816d3d7af3c4bef07f4a299ab65c74b7b8d80f9",
    "testharness"
   ],
   "css/css-scroll-anchoring/README.md": [
    "31205944cbcf321f7aa77e3bef0f8835cc7b6d13",
    "support"
   ],
   "css/css-scroll-anchoring/abspos-containing-block-outside-scroller.html": [
    "d7a8e9904637c833d897b2e9c0da0a1628455670",
@@ -612034,22 +612028,18 @@
   "webdriver/tests/send_alert_text/send.py": [
    "743b0285cb404d5a2aafde268f9ba7e574760bd1",
    "wdspec"
   ],
   "webdriver/tests/set_window_rect/__init__.py": [
    "da39a3ee5e6b4b0d3255bfef95601890afd80709",
    "support"
   ],
-  "webdriver/tests/set_window_rect/resizing_and_positioning.py": [
-   "479379109115668183643e8a050396219332887d",
-   "wdspec"
-  ],
   "webdriver/tests/set_window_rect/set.py": [
-   "f6202880dbdd4a407fa2944a68765757dbcb932b",
+   "79de443bc251f7effaa7c2ef3b95695f22db01c6",
    "wdspec"
   ],
   "webdriver/tests/set_window_rect/user_prompts.py": [
    "4ed66d05835d3ab229cb90928e0ca2a15ba08c8a",
    "wdspec"
   ],
   "webdriver/tests/status/__init__.py": [
    "da39a3ee5e6b4b0d3255bfef95601890afd80709",
deleted file mode 100644
--- a/testing/web-platform/tests/webdriver/tests/set_window_rect/resizing_and_positioning.py
+++ /dev/null
@@ -1,61 +0,0 @@
-import json
-import pytest
-import webdriver
-
-
-def window_size_supported(session):
-    try:
-        session.window.size = ("a", "b")
-    except webdriver.UnsupportedOperationException:
-        return False
-    except webdriver.InvalidArgumentException:
-        return True
-
-def window_position_supported(session):
-    try:
-        session.window.position = ("a", "b")
-    except webdriver.UnsupportedOperationException:
-        return False
-    except webdriver.InvalidArgumentException:
-        return True
-
-
-def test_window_resize(session):
-    if not window_size_supported(session):
-        pytest.skip()
-
-    # setting the window size by webdriver is synchronous
-    # so we should see the results immediately
-
-    session.window.size = (400, 500)
-    assert session.window.size == (400, 500)
-
-    session.window.size = (500, 600)
-    assert session.window.size == (500, 600)
-
-
-"""
-TODO(ato):
-
-    Disable test because the while statements are wrong.
-    To fix this properly we need to write an explicit wait utility.
-
-def test_window_resize_by_script(session):
-    # setting the window size by JS is asynchronous
-    # so we poll waiting for the results
-
-    size0 = session.window.size
-
-    session.execute_script("window.resizeTo(700, 800)")
-    size1 = session.window.size
-    while size0 == size1:
-        size1 = session.window.size
-    assert size1 == (700, 800)
-
-    session.execute_script("window.resizeTo(800, 900)")
-    size2 = session.window.size
-    while size1 == size2:
-        size2 = session.window.size
-        assert size2 == (800, 900)
-    assert size2 == {"width": 200, "height": 100}
-"""
--- a/testing/web-platform/tests/webdriver/tests/set_window_rect/set.py
+++ b/testing/web-platform/tests/webdriver/tests/set_window_rect/set.py
@@ -380,16 +380,43 @@ def test_resize_to_same_width(session):
 
 
 def test_resize_to_same_height(session):
     original_height = session.window.size[1]
     size = session.window.size = (456, original_height)
     assert size == (456, original_height)
 
 
+"""
+TODO(ato):
+
+    Disable test because the while statements are wrong.
+    To fix this properly we need to write an explicit wait utility.
+
+def test_resize_by_script(session):
+    # setting the window size by JS is asynchronous
+    # so we poll waiting for the results
+
+    size0 = session.window.size
+
+    session.execute_script("window.resizeTo(700, 800)")
+    size1 = session.window.size
+    while size0 == size1:
+        size1 = session.window.size
+    assert size1 == (700, 800)
+
+    session.execute_script("window.resizeTo(800, 900)")
+    size2 = session.window.size
+    while size1 == size2:
+        size2 = session.window.size
+        assert size2 == (800, 900)
+    assert size2 == {"width": 200, "height": 100}
+"""
+
+
 def test_payload(session):
     # step 14
     response = set_window_rect(session, {"x": 400, "y": 400})
 
     assert response.status == 200
     assert isinstance(response.body["value"], dict)
     value = response.body["value"]
     assert "width" in value