Bug 1453307 - Remove geckodriver::marionette trace logging. draft
authorHenrik Skupin <mail@hskupin.info>
Wed, 09 May 2018 10:21:36 +0200
changeset 794159 1db57fed71c6dd68eb88b93a7b9499df86af95a2
parent 792871 0cd106a2eb78aa04fd481785257e6f4f9b94707b
push id109582
push userbmo:hskupin@gmail.com
push dateFri, 11 May 2018 12:21:31 +0000
bugs1453307
milestone62.0a1
Bug 1453307 - Remove geckodriver::marionette trace logging. This patch removes the extra trace log entries from geckodriver which weren't useful for debugging in the past. MozReview-Commit-ID: FE94y8eVqpk
testing/geckodriver/src/marionette.rs
--- a/testing/geckodriver/src/marionette.rs
+++ b/testing/geckodriver/src/marionette.rs
@@ -1430,17 +1430,16 @@ impl MarionetteConnection {
         let resp_data = try!(self.send(command.to_json()));
         let json_data: Json = try!(Json::from_str(&*resp_data));
 
         self.session.response(msg, try!(MarionetteResponse::from_json(&json_data)))
     }
 
     fn send(&mut self, msg: Json) -> WebDriverResult<String> {
         let data = self.encode_msg(msg);
-        trace!("-> {}", data);
 
         match self.stream {
             Some(ref mut stream) => {
                 if stream.write(&*data.as_bytes()).is_err() {
                     let mut err = WebDriverError::new(ErrorStatus::UnknownError,
                                                       "Failed to write response to stream");
                     err.delete_session = true;
                     return Err(err);
@@ -1503,20 +1502,17 @@ impl MarionetteConnection {
             }
             total_read += num_read;
             for x in &buf[..num_read] {
                 payload.push(*x);
             }
         }
 
         // TODO(jgraham): Need to handle the error here
-        let data = String::from_utf8(payload).unwrap();
-        trace!("<- {}", data);
-
-        Ok(data)
+        Ok(String::from_utf8(payload).unwrap())
     }
 }
 
 trait ToMarionette {
     fn to_marionette(&self) -> WebDriverResult<BTreeMap<String, Json>>;
 }
 
 impl ToMarionette for GetParameters {