Bug 1455462 - Part 4. Use the async_task in devtool's zoom test. r?jdescottes draft
authorMantaroh Yoshinaga <mantaroh@gmail.com>
Fri, 11 May 2018 09:08:09 +0900
changeset 793950 a88106da7ebaa84ec8a645b8e95dd32991e82871
parent 793949 65e2d48158344298ac071d29cdacfc295dd77a4d
child 793951 b93096950db82b7c06048d3ab5249fce6f463303
push id109539
push userbmo:mantaroh@gmail.com
push dateFri, 11 May 2018 02:09:26 +0000
reviewersjdescottes
bugs1455462
milestone62.0a1
Bug 1455462 - Part 4. Use the async_task in devtool's zoom test. r?jdescottes This patch will change test to use the async_task before touching this tests and use the first decimal place when checking a result. MozReview-Commit-ID: DBkvLtEmEa3
devtools/client/framework/test/browser_toolbox_zoom.js
--- a/devtools/client/framework/test/browser_toolbox_zoom.js
+++ b/devtools/client/framework/test/browser_toolbox_zoom.js
@@ -1,67 +1,49 @@
-/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
-/* vim: set ft=javascript ts=2 et sw=2 tw=80: */
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
 "use strict";
 
-var toolbox;
-
 const {LocalizationHelper} = require("devtools/shared/l10n");
+const {Toolbox} = require("devtools/client/framework/toolbox");
 const L10N = new LocalizationHelper("devtools/client/locales/toolbox.properties");
 
-function test() {
-  addTab("about:blank").then(openToolbox);
-}
-
-function openToolbox() {
+add_task(async function() {
+  await addTab("about:blank");
   let target = TargetFactory.forTab(gBrowser.selectedTab);
+  let toolbox = await gDevTools.showToolbox(target,
+                                            "styleeditor",
+                                            Toolbox.HostType.BOTTOM);
 
-  gDevTools.showToolbox(target).then((aToolbox) => {
-    toolbox = aToolbox;
-    toolbox.selectTool("styleeditor").then(testZoom);
-  });
-}
-
-function testZoom() {
   info("testing zoom keys");
 
-  testZoomLevel("In", 2, 1.2);
-  testZoomLevel("Out", 3, 0.9);
-  testZoomLevel("Reset", 1, 1);
+  testZoomLevel("In", 2, 1.2, toolbox);
+  testZoomLevel("Out", 3, 0.9, toolbox);
+  testZoomLevel("Reset", 1, 1, toolbox);
 
-  tidyUp();
-}
+  await toolbox.destroy();
+  gBrowser.removeCurrentTab();
+});
 
-function testZoomLevel(type, times, expected) {
+function testZoomLevel(type, times, expected, toolbox) {
   sendZoomKey("toolbox.zoom" + type + ".key", times);
 
   let zoom = getCurrentZoom(toolbox);
-  is(zoom.toFixed(2), expected, "zoom level correct after zoom " + type);
+  is(zoom.toFixed(1), expected, "zoom level correct after zoom " + type);
 
   let savedZoom = parseFloat(Services.prefs.getCharPref(
     "devtools.toolbox.zoomValue"));
-  is(savedZoom.toFixed(2), expected,
+  is(savedZoom.toFixed(1), expected,
      "saved zoom level is correct after zoom " + type);
 }
 
 function sendZoomKey(shortcut, times) {
   for (let i = 0; i < times; i++) {
     synthesizeKeyShortcut(L10N.getStr(shortcut));
   }
 }
 
-function getCurrentZoom() {
+function getCurrentZoom(toolbox) {
   let windowUtils = toolbox.win.QueryInterface(Ci.nsIInterfaceRequestor)
     .getInterface(Ci.nsIDOMWindowUtils);
   return windowUtils.fullZoom;
 }
-
-function tidyUp() {
-  toolbox.destroy().then(function() {
-    gBrowser.removeCurrentTab();
-
-    toolbox = null;
-    finish();
-  });
-}