Bug 1418627 - make sure to test window data at a positive array index, otherwise it may be null. draft bug-1418627
authorMike de Boer <mdeboer@mozilla.com>
Tue, 08 May 2018 13:57:14 +0200
changeset 792390 afba8a051d4330d0b35235b5a992bdff7dcb2f37
parent 792270 59005ba3cd3e7b3f9e8804bea881bf4c3a755d7c
push id109106
push usermdeboer@mozilla.com
push dateTue, 08 May 2018 11:58:14 +0000
bugs1418627
milestone62.0a1
Bug 1418627 - make sure to test window data at a positive array index, otherwise it may be null. MozReview-Commit-ID: 8ImoHwxYKYP
browser/components/sessionstore/test/browser_524745.js
--- a/browser/components/sessionstore/test/browser_524745.js
+++ b/browser/components/sessionstore/test/browser_524745.js
@@ -18,17 +18,17 @@ function test() {
       let selectedWindow = state.windows[state.selectedWindow - 1];
       is(selectedWindow.extData && selectedWindow.extData[uniqKey], uniqVal,
          "selectedWindow is window_B");
 
       // Now minimize window_B. The selected window shouldn't have the secret data
       window_B.minimize();
       waitForFocus(function() {
         state = JSON.parse(ss.getBrowserState());
-        selectedWindow = state.windows[state.selectedWindow - 1];
+        selectedWindow = state.windows[Math.ceil(state.selectedWindow - 1, 0)];
         ok(!selectedWindow.extData || !selectedWindow.extData[uniqKey],
            "selectedWindow is not window_B after minimizing it");
 
         // Now minimize the last open window (assumes no other tests left windows open)
         window.minimize();
         state = JSON.parse(ss.getBrowserState());
         is(state.selectedWindow, 0,
            "selectedWindow should be 0 when all windows are minimized");