Bug 1456394 - Make TimingParameters::operator== compare end delay values; r?hiro draft
authorBrian Birtles <birtles@gmail.com>
Mon, 07 May 2018 12:42:24 +0900
changeset 794001 9efc55b04eefa52a1d1cd75afc167eae9eb6ed4d
parent 794000 2dc4aecf8f8c476ea8b4a6e3d4e6b68a2005df7f
child 794002 5d80255062cbd88ea616d47a770d4ecb8e3ddbce
push id109561
push userbmo:bbirtles@mozilla.com
push dateFri, 11 May 2018 06:43:46 +0000
reviewershiro
bugs1456394
milestone62.0a1
Bug 1456394 - Make TimingParameters::operator== compare end delay values; r?hiro MozReview-Commit-ID: 5frk5APUTDd
dom/animation/TimingParams.cpp
testing/web-platform/meta/web-animations/interfaces/Animatable/getAnimations.html.ini
testing/web-platform/meta/web-animations/interfaces/AnimationEffect/updateTiming.html.ini
--- a/dom/animation/TimingParams.cpp
+++ b/dom/animation/TimingParams.cpp
@@ -224,16 +224,17 @@ TimingParams::ParseEasing(const nsAStrin
 
 bool
 TimingParams::operator==(const TimingParams& aOther) const
 {
   // We don't compare mActiveDuration and mEndTime because they are calculated
   // from other timing parameters.
   return mDuration == aOther.mDuration &&
          mDelay == aOther.mDelay &&
+         mEndDelay == aOther.mEndDelay &&
          mIterations == aOther.mIterations &&
          mIterationStart == aOther.mIterationStart &&
          mDirection == aOther.mDirection &&
          mFill == aOther.mFill &&
          mFunction == aOther.mFunction;
 }
 
 } // namespace mozilla
deleted file mode 100644
--- a/testing/web-platform/meta/web-animations/interfaces/Animatable/getAnimations.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[getAnimations.html]
-  [Returns animations based on dynamic changes to individual animations' end delay]
-    expected: FAIL
-
deleted file mode 100644
--- a/testing/web-platform/meta/web-animations/interfaces/AnimationEffect/updateTiming.html.ini
+++ /dev/null
@@ -1,7 +0,0 @@
-[updateTiming.html]
-  [Allows setting the endDelay to a positive number]
-    expected: FAIL
-
-  [Allows setting the endDelay to a negative number]
-    expected: FAIL
-