Bug 1434872 - [marionette] Fix remote_page checks in bf_cache navigtion tests.
Currently the remote check only gets performed for the very last page
of each bfcache test. Instead it has to be executed for each individual
web page as loaded.
MozReview-Commit-ID: IIqnLy4RhZ5
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py
@@ -379,34 +379,34 @@ class TestBackForwardNavigation(BaseNavi
for page in test_pages[-2::-1]:
if "error" in page:
with self.assertRaises(page["error"]):
self.marionette.go_back()
else:
self.marionette.go_back()
self.assertEqual(page["url"], self.marionette.get_url())
- if "is_remote" in page:
- self.assertEqual(page["is_remote"], self.is_remote_tab,
- "'{}' doesn't match expected remoteness state: {}".format(
- page["url"], page["is_remote"]))
+ if "is_remote" in page:
+ self.assertEqual(page["is_remote"], self.is_remote_tab,
+ "'{}' doesn't match expected remoteness state: {}".format(
+ page["url"], page["is_remote"]))
# Now going forward in history by skipping the first entry.
for page in test_pages[1::]:
if "error" in page:
with self.assertRaises(page["error"]):
self.marionette.go_forward()
else:
self.marionette.go_forward()
self.assertEqual(page["url"], self.marionette.get_url())
- if "is_remote" in page:
- self.assertEqual(page["is_remote"], self.is_remote_tab,
- "'{}' doesn't match expected remoteness state: {}".format(
- page["url"], page["is_remote"]))
+ if "is_remote" in page:
+ self.assertEqual(page["is_remote"], self.is_remote_tab,
+ "'{}' doesn't match expected remoteness state: {}".format(
+ page["url"], page["is_remote"]))
def test_no_history_items(self):
# Both methods should not raise a failure if no navigation is possible
self.marionette.go_back()
self.marionette.go_forward()
def test_data_urls(self):
test_pages = [