Bug 1434872 - [marionette] Fix remote_page checks in bf_cache navigtion tests. draft
authorHenrik Skupin <mail@hskupin.info>
Sat, 05 May 2018 17:04:58 +0200
changeset 793241 c46ca2dce2da51c6a5d218d4564bbe5ca04c2301
parent 793240 4be2960b7f7591df9c541dbd16767c8451745834
child 793242 ff8e513a0a7f93631bfa477fcc8318c8419e2254
push id109323
push userbmo:hskupin@gmail.com
push dateWed, 09 May 2018 19:25:09 +0000
bugs1434872
milestone62.0a1
Bug 1434872 - [marionette] Fix remote_page checks in bf_cache navigtion tests. Currently the remote check only gets performed for the very last page of each bfcache test. Instead it has to be executed for each individual web page as loaded. MozReview-Commit-ID: IIqnLy4RhZ5
testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py
@@ -379,34 +379,34 @@ class TestBackForwardNavigation(BaseNavi
         for page in test_pages[-2::-1]:
             if "error" in page:
                 with self.assertRaises(page["error"]):
                     self.marionette.go_back()
             else:
                 self.marionette.go_back()
             self.assertEqual(page["url"], self.marionette.get_url())
 
-        if "is_remote" in page:
-            self.assertEqual(page["is_remote"], self.is_remote_tab,
-                             "'{}' doesn't match expected remoteness state: {}".format(
-                                 page["url"], page["is_remote"]))
+            if "is_remote" in page:
+                self.assertEqual(page["is_remote"], self.is_remote_tab,
+                                 "'{}' doesn't match expected remoteness state: {}".format(
+                                     page["url"], page["is_remote"]))
 
         # Now going forward in history by skipping the first entry.
         for page in test_pages[1::]:
             if "error" in page:
                 with self.assertRaises(page["error"]):
                     self.marionette.go_forward()
             else:
                 self.marionette.go_forward()
             self.assertEqual(page["url"], self.marionette.get_url())
 
-        if "is_remote" in page:
-            self.assertEqual(page["is_remote"], self.is_remote_tab,
-                             "'{}' doesn't match expected remoteness state: {}".format(
-                                 page["url"], page["is_remote"]))
+            if "is_remote" in page:
+                self.assertEqual(page["is_remote"], self.is_remote_tab,
+                                 "'{}' doesn't match expected remoteness state: {}".format(
+                                     page["url"], page["is_remote"]))
 
     def test_no_history_items(self):
         # Both methods should not raise a failure if no navigation is possible
         self.marionette.go_back()
         self.marionette.go_forward()
 
     def test_data_urls(self):
         test_pages = [