Bug 1454591 part 4 - Have devtools test not rely on font-family being the first longhand of font shorthand. r?tromey draft
authorXidorn Quan <me@upsuper.org>
Fri, 04 May 2018 21:13:51 +1000
changeset 791424 f8a3e47aa4d265cf670078c93993776c2439dc7e
parent 791365 13b76ba90225edb1713834c43b6b9309fd74587e
child 791425 adffa602ea57242f4efe4a0d08b3e33df983a7dc
push id108809
push userxquan@mozilla.com
push dateFri, 04 May 2018 11:15:53 +0000
reviewerstromey
bugs1454591
milestone61.0a1
Bug 1454591 part 4 - Have devtools test not rely on font-family being the first longhand of font shorthand. r?tromey MozReview-Commit-ID: 2URKcAOcCdV
devtools/client/inspector/shared/test/browser_styleinspector_tooltip-shorthand-fontfamily.js
--- a/devtools/client/inspector/shared/test/browser_styleinspector_tooltip-shorthand-fontfamily.js
+++ b/devtools/client/inspector/shared/test/browser_styleinspector_tooltip-shorthand-fontfamily.js
@@ -36,18 +36,25 @@ async function testRuleView(ruleView, no
 
   // Get the computed font family property inside the font rule view
   let propertyList = ruleView.element
     .querySelectorAll(".ruleview-propertylist");
   let fontExpander = propertyList[1].querySelectorAll(".ruleview-expander")[0];
   fontExpander.click();
 
   let rule = getRuleViewRule(ruleView, "#testElement");
-  let valueSpan = rule
-    .querySelector(".ruleview-computed .ruleview-propertyvalue");
+  let computedlist = rule.querySelectorAll(".ruleview-computed");
+  let valueSpan;
+  for (let computed of computedlist) {
+    let propertyName = computed.querySelector(".ruleview-propertyname");
+    if (propertyName.textContent == "font-family") {
+      valueSpan = computed.querySelector(".ruleview-propertyvalue");
+      break;
+    }
+  }
 
   // And verify that the tooltip gets shown on this property
   let previewTooltip = await assertShowPreviewTooltip(ruleView, valueSpan);
 
   let images = panel.getElementsByTagName("img");
   is(images.length, 1, "Tooltip contains an image");
   ok(images[0].getAttribute("src")
     .startsWith("data:"), "Tooltip contains a data-uri image as expected");