Bug 1458814: Remove unused AnimationValue::mGecko. r?hiro draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Thu, 03 May 2018 18:31:54 +0200
changeset 791164 fc61ca4f024976349f8ed7b57ec2f3431c4e55d2
parent 791163 1e2705ef96f9c79112a60ad3e7cb2b2f9615a8a3
child 791165 38745eca45f00132fd644cbbbef1e7eb0bf39d05
push id108716
push userbmo:emilio@crisal.io
push dateThu, 03 May 2018 16:54:43 +0000
reviewershiro
bugs1458814
milestone61.0a1
Bug 1458814: Remove unused AnimationValue::mGecko. r?hiro MozReview-Commit-ID: I0TJsSQYe5t
layout/style/StyleAnimationValue.h
--- a/layout/style/StyleAnimationValue.h
+++ b/layout/style/StyleAnimationValue.h
@@ -76,18 +76,17 @@ struct AnimationValue
     return !mServo;
   }
 
   float GetOpacity() const;
 
   // Return the transform list as a RefPtr.
   already_AddRefed<const nsCSSValueSharedList> GetTransformList() const;
 
-  // Return the scale for mGecko or mServo, which are calculated with
-  // reference to aFrame.
+  // Return the scale for mServo, which is calculated with reference to aFrame.
   mozilla::gfx::Size GetScaleValue(const nsIFrame* aFrame) const;
 
   // Uncompute this AnimationValue and then serialize it.
   void SerializeSpecifiedValue(nsCSSPropertyID aProperty,
                                nsAString& aString) const;
 
   // Check if |*this| and |aToValue| can be interpolated.
   bool IsInterpolableWith(nsCSSPropertyID aProperty,
@@ -111,26 +110,16 @@ struct AnimationValue
   static AnimationValue Opacity(float aOpacity);
   // Create an AnimationValue from a transform list.
   static AnimationValue Transform(nsCSSValueSharedList& aList);
 
   static already_AddRefed<nsCSSValue::Array>
   AppendTransformFunction(nsCSSKeyword aTransformFunction,
                           nsCSSValueList**& aListTail);
 
-  // mGecko and mServo are mutually exclusive: only one or the other should
-  // ever be set.
-  // FIXME: After obsoleting StyleAnimationValue, we should remove mGecko, and
-  // make AnimationValue a wrapper of RawServoAnimationValue to hide these
-  // FFIs.
-  // Ideally we would use conditional compilation based on MOZ_OLD_STYLE in the
-  // Servo code that wants to initialize mGecko, but that seems tricky.  So for
-  // now, just define a dummy member variable that its initialization code will
-  // work on, even when the old style system is compiled out.
-  uintptr_t mGecko;
   RefPtr<RawServoAnimationValue> mServo;
 };
 
 struct PropertyStyleAnimationValuePair
 {
   nsCSSPropertyID mProperty;
   AnimationValue mValue;
 };