Bug 1458063 - Propagate event modifiers for wheel events in APZInputBridge::ReceiveInputEvent. r=kats draft
authorBotond Ballo <botond@mozilla.com>
Mon, 30 Apr 2018 17:48:22 -0400
changeset 790799 a2cc6fd9d6259071545ddbd48b738429bfa1c71f
parent 789727 63519bfd42ee379f597c0357af2e712ec3cd9f50
child 790800 60b2ed1902a6c13290f5ae04f1f82611b701016d
child 790810 d407396d2a78203a530102e5fe17f486eb50e12a
child 790824 2ea04360700530e1fbbbaaf94b484b6df2f79fe4
push id108597
push userbballo@mozilla.com
push dateWed, 02 May 2018 20:55:49 +0000
reviewerskats
bugs1458063
milestone61.0a1
Bug 1458063 - Propagate event modifiers for wheel events in APZInputBridge::ReceiveInputEvent. r=kats MozReview-Commit-ID: 8X3xfEk9uWQ
gfx/layers/apz/src/APZInputBridge.cpp
--- a/gfx/layers/apz/src/APZInputBridge.cpp
+++ b/gfx/layers/apz/src/APZInputBridge.cpp
@@ -128,17 +128,18 @@ APZInputBridge::ReceiveInputEvent(
         WheelDeltaHorizontalizer horizontalizer(wheelEvent);
         if (WheelDeltaAdjustmentStrategy::eHorizontalize == strategy) {
           horizontalizer.Horizontalize();
         }
 
         // If the wheel event becomes no-op event, don't handle it as scroll.
         if (wheelEvent.mDeltaX || wheelEvent.mDeltaY) {
           ScreenPoint origin(wheelEvent.mRefPoint.x, wheelEvent.mRefPoint.y);
-          ScrollWheelInput input(wheelEvent.mTime, wheelEvent.mTimeStamp, 0,
+          ScrollWheelInput input(wheelEvent.mTime, wheelEvent.mTimeStamp,
+                                 wheelEvent.mModifiers,
                                  scrollMode,
                                  ScrollWheelInput::DeltaTypeForDeltaMode(
                                                      wheelEvent.mDeltaMode),
                                  origin,
                                  wheelEvent.mDeltaX, wheelEvent.mDeltaY,
                                  wheelEvent.mAllowToOverrideSystemScrollSpeed,
                                  strategy);