Bug 1457863 - 1. Update kotlin to 1.2.41; r?nalexander draft
authorJim Chen <nchen@mozilla.com>
Wed, 02 May 2018 13:49:57 -0400
changeset 790753 3236472cb01694fb2c9aad791b225eacd4364796
parent 790752 ebe272851eac9abf9a3d6449ada7fc87928b54e1
child 790754 c6470b25c63fa54fed35df0e487eddfb3413747f
push id108571
push userbmo:nchen@mozilla.com
push dateWed, 02 May 2018 17:50:53 +0000
reviewersnalexander
bugs1457863
milestone61.0a1
Bug 1457863 - 1. Update kotlin to 1.2.41; r?nalexander Update the kotlin version used for GeckoView tests to 1.2.41. Also turn on "warnings-as-errors", which is a compiler option introduced in kotlin 1.2. MozReview-Commit-ID: 7cL2v4jFJ27
build.gradle
mobile/android/geckoview/build.gradle
--- a/build.gradle
+++ b/build.gradle
@@ -45,17 +45,17 @@ buildscript {
             }
         }
         // For in tree plugins.
         maven {
             url "file://${gradle.mozconfig.topsrcdir}/mobile/android/gradle/m2repo"
         }
     }
 
-    ext.kotlin_version = '1.1.51'
+    ext.kotlin_version = '1.2.41'
     ext.support_library_version = '23.4.0'
 
     if (gradle.mozconfig.substs.MOZ_ANDROID_GOOGLE_PLAY_SERVICES) {
         ext.google_play_services_version = '8.4.0'
     }
 
     dependencies {
         classpath 'com.android.tools.build:gradle:3.0.1'
--- a/mobile/android/geckoview/build.gradle
+++ b/mobile/android/geckoview/build.gradle
@@ -169,16 +169,20 @@ tasks.withType(org.jetbrains.kotlin.grad
             }
             def (_, type, file, line, column, message) = matches[0]
             type = (type == 'w') ? 'warning' : 'error'
             // Use logger.lifecycle, which does not go through stderr again.
             logger.lifecycle "$file:$line:$column: $type: $message"
         }
     } as StandardOutputListener
 
+    kotlinOptions {
+        allWarningsAsErrors = true
+    }
+
     doFirst {
         logging.addStandardErrorListener(listener)
     }
     doLast {
         logging.removeStandardErrorListener(listener)
     }
 }