Bug 1452445 - Promote MOZ_LOG calls to NS_WARNING in LookupCacheV4. r?gcp draft
authorFrancois Marier <francois@mozilla.com>
Mon, 30 Apr 2018 16:44:35 -0700
changeset 790018 f69e48aca44685081f09e2ead95a8e46f060af33
parent 790006 7ef8450810693ab08e79ab0d4702de6f479e678c
push id108389
push userfmarier@mozilla.com
push dateMon, 30 Apr 2018 23:44:52 +0000
reviewersgcp
bugs1452445
milestone61.0a1
Bug 1452445 - Promote MOZ_LOG calls to NS_WARNING in LookupCacheV4. r?gcp This should help narrow down which of the code paths is responsible for the intermittent failures we are seeing. MozReview-Commit-ID: JHVZzixpOg6
toolkit/components/url-classifier/LookupCacheV4.cpp
--- a/toolkit/components/url-classifier/LookupCacheV4.cpp
+++ b/toolkit/components/url-classifier/LookupCacheV4.cpp
@@ -476,19 +476,19 @@ WriteValue(nsIOutputStream *aOutputStrea
     nsresult rv = WriteValue(aOutputStream, writeLength);
     NS_ENSURE_SUCCESS(rv, rv);
   }
 
   // Write out the value.
   auto valueReadPtr = ValueTraits<T>::ReadPtr(aValue);
   uint32_t written;
   nsresult rv = aOutputStream->Write(valueReadPtr, writeLength, &written);
-  if (NS_FAILED(rv) || written != writeLength) {
-    LOG(("Failed to write the value."));
-    return NS_FAILED(rv) ? rv : NS_ERROR_FAILURE;
+  NS_ENSURE_SUCCESS(rv, rv);
+  if (NS_WARN_IF(written != writeLength)) {
+    return NS_ERROR_FAILURE;
   }
 
   return rv;
 }
 
 template<typename T> static nsresult
 ReadValue(nsIInputStream* aInputStream, T& aValue)
 {
@@ -537,34 +537,25 @@ LookupCacheV4::WriteMetadata(TableUpdate
   NS_ENSURE_SUCCESS(rv, rv);
 
   rv = metaFile->AppendNative(mTableName + METADATA_SUFFIX);
   NS_ENSURE_SUCCESS(rv, rv);
 
   nsCOMPtr<nsIOutputStream> outputStream;
   rv = NS_NewLocalFileOutputStream(getter_AddRefs(outputStream), metaFile,
                                    PR_WRONLY | PR_TRUNCATE | PR_CREATE_FILE);
-  if (!NS_SUCCEEDED(rv)) {
-    LOG(("Unable to create file to store metadata."));
-    return rv;
-  }
+  NS_ENSURE_SUCCESS(rv, rv);
 
   // Write the state.
   rv = WriteValue(outputStream, aTableUpdate->ClientState());
-  if (NS_FAILED(rv)) {
-    LOG(("Failed to write the list state."));
-    return rv;
-  }
+  NS_ENSURE_SUCCESS(rv, rv);
 
   // Write the checksum.
   rv = WriteValue(outputStream, aTableUpdate->Checksum());
-  if (NS_FAILED(rv)) {
-    LOG(("Failed to write the list checksum."));
-    return rv;
-  }
+  NS_ENSURE_SUCCESS(rv, rv);
 
   return rv;
 }
 
 nsresult
 LookupCacheV4::LoadMetadata(nsACString& aState, nsACString& aChecksum)
 {
   nsCOMPtr<nsIFile> metaFile;