Bug 1396185 - [wdspec] Fix linter failures in get_title.py. draft
authorHenrik Skupin <mail@hskupin.info>
Thu, 26 Apr 2018 22:48:00 +0200
changeset 790788 490e09549e964f4ac9296f8941d10829cb307e6f
parent 790787 f2718a72699d2666974ad0ff006f5fb75bfe10dd
child 790789 c4afaae900ce6bae3833965df54549f11622de2b
push id108589
push userbmo:hskupin@gmail.com
push dateWed, 02 May 2018 19:44:24 +0000
bugs1396185
milestone61.0a1
Bug 1396185 - [wdspec] Fix linter failures in get_title.py. MozReview-Commit-ID: KxrB69Bakcv
testing/web-platform/tests/webdriver/tests/navigation/get_title.py
--- a/testing/web-platform/tests/webdriver/tests/navigation/get_title.py
+++ b/testing/web-platform/tests/webdriver/tests/navigation/get_title.py
@@ -1,15 +1,13 @@
-import pytest
-import time
-
 from tests.support.asserts import assert_error, assert_success, assert_dialog_handled
 from tests.support.fixtures import create_dialog
 from tests.support.inline import inline
 
+
 def read_global(session, name):
     return session.execute_script("return %s;" % name)
 
 
 def get_title(session):
     return session.transport.send(
         "GET", "session/{session_id}/title".format(**vars(session)))
 
@@ -19,63 +17,65 @@ def test_no_browsing_context(session, cr
     session.window_handle = new_window
     session.close()
 
     result = get_title(session)
     assert_error(result, "no such window")
 
 
 def test_title_handle_prompt_dismiss(new_session, add_browser_capabilites):
-    _, session = new_session({"capabilities": {"alwaysMatch": add_browser_capabilites({"unhandledPromptBehavior": "dismiss"})}})
+    _, session = new_session({"capabilities": {
+        "alwaysMatch": add_browser_capabilites({"unhandledPromptBehavior": "dismiss"})}})
     session.url = inline("<title>WD doc title</title>")
 
     expected_title = read_global(session, "document.title")
     create_dialog(session)("alert", text="dismiss #1", result_var="dismiss1")
 
     result = get_title(session)
     assert_success(result, expected_title)
     assert_dialog_handled(session, "dismiss #1")
-    assert read_global(session, "dismiss1") == None
+    assert read_global(session, "dismiss1") is None
 
     expected_title = read_global(session, "document.title")
     create_dialog(session)("confirm", text="dismiss #2", result_var="dismiss2")
 
     result = get_title(session)
     assert_success(result, expected_title)
     assert_dialog_handled(session, "dismiss #2")
-    assert read_global(session, "dismiss2") == False
+    assert read_global(session, "dismiss2") is False
 
     expected_title = read_global(session, "document.title")
     create_dialog(session)("prompt", text="dismiss #3", result_var="dismiss3")
 
     result = get_title(session)
     assert_success(result, expected_title)
     assert_dialog_handled(session, "dismiss #3")
-    assert read_global(session, "dismiss3") == None
+    assert read_global(session, "dismiss3") is None
 
 
 def test_title_handle_prompt_accept(new_session, add_browser_capabilites):
-    _, session = new_session({"capabilities": {"alwaysMatch": add_browser_capabilites({"unhandledPromptBehavior": "accept"})}})
+    _, session = new_session({"capabilities": {
+        "alwaysMatch": add_browser_capabilites({"unhandledPromptBehavior": "accept"})}})
     session.url = inline("<title>WD doc title</title>")
     create_dialog(session)("alert", text="accept #1", result_var="accept1")
 
     expected_title = read_global(session, "document.title")
 
     result = get_title(session)
     assert_success(result, expected_title)
     assert_dialog_handled(session, "accept #1")
-    assert read_global(session, "accept1") == None
+    assert read_global(session, "accept1") is None
 
     expected_title = read_global(session, "document.title")
     create_dialog(session)("confirm", text="accept #2", result_var="accept2")
 
     result = get_title(session)
     assert_success(result, expected_title)
     assert_dialog_handled(session, "accept #2")
-    assert read_global(session, "accept2") == True
+    assert read_global(session, "accept2") is True
 
     expected_title = read_global(session, "document.title")
     create_dialog(session)("prompt", text="accept #3", result_var="accept3")
 
     result = get_title(session)
     assert_success(result, expected_title)
     assert_dialog_handled(session, "accept #3")
     assert read_global(session, "accept3") == "" or read_global(session, "accept3") == "undefined"
@@ -83,37 +83,37 @@ def test_title_handle_prompt_accept(new_
 
 def test_title_handle_prompt_missing_value(session, create_dialog):
     session.url = inline("<title>WD doc title</title>")
     create_dialog("alert", text="dismiss #1", result_var="dismiss1")
 
     result = get_title(session)
     assert_error(result, "unexpected alert open")
     assert_dialog_handled(session, "dismiss #1")
-    assert read_global(session, "dismiss1") == None
+    assert read_global(session, "dismiss1") is None
 
     create_dialog("confirm", text="dismiss #2", result_var="dismiss2")
 
     result = get_title(session)
     assert_error(result, "unexpected alert open")
     assert_dialog_handled(session, "dismiss #2")
-    assert read_global(session, "dismiss2") == False
+    assert read_global(session, "dismiss2") is False
 
     create_dialog("prompt", text="dismiss #3", result_var="dismiss3")
 
     result = get_title(session)
     assert_error(result, "unexpected alert open")
     assert_dialog_handled(session, "dismiss #3")
-    assert read_global(session, "dismiss3") == None
+    assert read_global(session, "dismiss3") is None
 
 # The behavior of the `window.print` function is platform-dependent and may not
 # trigger the creation of a dialog at all. Therefore, this test should only be
 # run in contexts that support the dialog (a condition that may not be
 # determined automatically).
-#def test_title_with_non_simple_dialog(session):
+# def test_title_with_non_simple_dialog(session):
 #    document = "<title>With non-simple dialog</title><h2>Hello</h2>"
 #    spawn = """
 #        var done = arguments[0];
 #        setTimeout(function() {
 #            done();
 #        }, 0);
 #        setTimeout(function() {
 #            window['print']();