Bug 1456996 - [wdspec] Fix test_duplicated_cookie for invalid domain usage. draft
authorHenrik Skupin <mail@hskupin.info>
Thu, 26 Apr 2018 08:06:02 +0200
changeset 788292 08cbb5a14cd414e4c408908f39bc6cde93a97d65
parent 788291 41839b8d53603d034bf8f2dbb57c53381ca870f9
push id107943
push userbmo:hskupin@gmail.com
push dateThu, 26 Apr 2018 06:08:24 +0000
bugs1456996
milestone61.0a1
Bug 1456996 - [wdspec] Fix test_duplicated_cookie for invalid domain usage. MozReview-Commit-ID: 9JDmCxxJvAt
testing/web-platform/meta/webdriver/tests/cookies/get_named_cookie.py.ini
testing/web-platform/tests/webdriver/tests/cookies/get_named_cookie.py
deleted file mode 100644
--- a/testing/web-platform/meta/webdriver/tests/cookies/get_named_cookie.py.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[get_named_cookie.py]
-  [test_duplicated_cookie]
-    expected: FAIL
-
--- a/testing/web-platform/tests/webdriver/tests/cookies/get_named_cookie.py
+++ b/testing/web-platform/tests/webdriver/tests/cookies/get_named_cookie.py
@@ -65,38 +65,39 @@ def test_get_named_cookie(session, url):
     assert cookie["name"] == "foo"
     assert cookie["value"] == "bar"
     # convert from seconds since epoch
     assert datetime.utcfromtimestamp(
         cookie["expiry"]).strftime(utc_string_format) == a_year_from_now
 
 
 def test_duplicated_cookie(session, url, server_config):
+    new_cookie = {
+        "name": "hello",
+        "value": "world",
+        "domain": server_config["browser_host"],
+        "path": "/",
+        "http_only": False,
+        "secure": False
+    }
+
     session.url = url("/common/blank.html")
     clear_all_cookies(session)
-    create_cookie_request = {
-        "cookie": {
-            "name": "hello",
-            "value": "world",
-            "domain": server_config["domains"][""],
-            "path": "/",
-            "httpOnly": False,
-            "secure": False
-        }
-    }
-    result = session.transport.send("POST", "session/%s/cookie" % session.session_id, create_cookie_request)
-    assert result.status == 200
-    assert "value" in result.body
-    assert result.body["value"] is None
 
-    session.url = inline("<script>document.cookie = 'hello=newworld; domain=%s; path=/';</script>" % server_config["domains"][""])
+    session.set_cookie(**new_cookie)
+    session.url = inline("""
+      <script>
+        document.cookie = '{name}=newworld; domain={domain}; path=/';
+      </script>""".format(
+        name=new_cookie["name"],
+        domain=server_config["browser_host"]))
 
-    result = get_named_cookie(session, "hello")
+    result = get_named_cookie(session, new_cookie["name"])
     cookie = assert_success(result)
     assert isinstance(cookie, dict)
 
     assert "name" in cookie
     assert isinstance(cookie["name"], basestring)
     assert "value" in cookie
     assert isinstance(cookie["value"], basestring)
 
-    assert cookie["name"] == "hello"
+    assert cookie["name"] == new_cookie["name"]
     assert cookie["value"] == "newworld"