Bug 1455745: Remove more accessibility related diagnostic crashes on Nightly. r=aklotz
This condition is rare and does indicate a problem which breaks accessibility.
However, we aren't getting any closer to diagnosing this as a result of this crash, so it causes user pain without any gain to us.
MozReview-Commit-ID: GacAQDbhB0h
--- a/accessible/generic/DocAccessible.cpp
+++ b/accessible/generic/DocAccessible.cpp
@@ -1467,17 +1467,17 @@ DocAccessible::DoInitialUpdate()
DocAccessibleChild* ipcDoc = new DocAccessibleChild(this, tabChild);
SetIPCDoc(ipcDoc);
if (IsRoot()) {
tabChild->SetTopLevelDocAccessibleChild(ipcDoc);
}
#if defined(XP_WIN)
IAccessibleHolder holder(CreateHolderFromAccessible(WrapNotNull(this)));
- MOZ_DIAGNOSTIC_ASSERT(!holder.IsNull());
+ MOZ_ASSERT(!holder.IsNull());
int32_t childID = AccessibleWrap::GetChildIDFor(this);
#else
int32_t holder = 0, childID = 0;
#endif
tabChild->SendPDocAccessibleConstructor(ipcDoc, nullptr, 0, childID,
holder);
}
}
--- a/accessible/ipc/win/COMPtrTypes.cpp
+++ b/accessible/ipc/win/COMPtrTypes.cpp
@@ -46,17 +46,17 @@ CreateHolderFromAccessible(NotNull<Acces
if (useHandler) {
payload = new HandlerProvider(IID_IAccessible,
mscom::ToInterceptorTargetPtr(iaToProxy));
}
ProxyUniquePtr<IAccessible> intercepted;
HRESULT hr = MainThreadHandoff::WrapInterface(Move(iaToProxy), payload,
(IAccessible**) mscom::getter_AddRefs(intercepted));
- MOZ_DIAGNOSTIC_ASSERT(SUCCEEDED(hr));
+ MOZ_ASSERT(SUCCEEDED(hr));
if (FAILED(hr)) {
return nullptr;
}
return IAccessibleHolder(Move(intercepted));
}
IHandlerControlHolder