Bug 1455745: Remove more accessibility related diagnostic crashes on Nightly. r=aklotz draft
authorJames Teh <jteh@mozilla.com>
Mon, 23 Apr 2018 12:27:17 +1000
changeset 786369 ee1dc7d17420383df9bb12ed32965e3d8ec1b17d
parent 786291 8d4cf28964f6956cd22d8710b316456e2c7c848d
push id107442
push userbmo:jteh@mozilla.com
push dateMon, 23 Apr 2018 03:49:22 +0000
reviewersaklotz
bugs1455745
milestone61.0a1
Bug 1455745: Remove more accessibility related diagnostic crashes on Nightly. r=aklotz This condition is rare and does indicate a problem which breaks accessibility. However, we aren't getting any closer to diagnosing this as a result of this crash, so it causes user pain without any gain to us. MozReview-Commit-ID: GacAQDbhB0h
accessible/generic/DocAccessible.cpp
accessible/ipc/win/COMPtrTypes.cpp
--- a/accessible/generic/DocAccessible.cpp
+++ b/accessible/generic/DocAccessible.cpp
@@ -1467,17 +1467,17 @@ DocAccessible::DoInitialUpdate()
         DocAccessibleChild* ipcDoc = new DocAccessibleChild(this, tabChild);
         SetIPCDoc(ipcDoc);
         if (IsRoot()) {
           tabChild->SetTopLevelDocAccessibleChild(ipcDoc);
         }
 
 #if defined(XP_WIN)
         IAccessibleHolder holder(CreateHolderFromAccessible(WrapNotNull(this)));
-        MOZ_DIAGNOSTIC_ASSERT(!holder.IsNull());
+        MOZ_ASSERT(!holder.IsNull());
         int32_t childID = AccessibleWrap::GetChildIDFor(this);
 #else
         int32_t holder = 0, childID = 0;
 #endif
         tabChild->SendPDocAccessibleConstructor(ipcDoc, nullptr, 0, childID,
                                                 holder);
       }
     }
--- a/accessible/ipc/win/COMPtrTypes.cpp
+++ b/accessible/ipc/win/COMPtrTypes.cpp
@@ -46,17 +46,17 @@ CreateHolderFromAccessible(NotNull<Acces
   if (useHandler) {
     payload = new HandlerProvider(IID_IAccessible,
                                   mscom::ToInterceptorTargetPtr(iaToProxy));
   }
 
   ProxyUniquePtr<IAccessible> intercepted;
   HRESULT hr = MainThreadHandoff::WrapInterface(Move(iaToProxy), payload,
                                                 (IAccessible**) mscom::getter_AddRefs(intercepted));
-  MOZ_DIAGNOSTIC_ASSERT(SUCCEEDED(hr));
+  MOZ_ASSERT(SUCCEEDED(hr));
   if (FAILED(hr)) {
     return nullptr;
   }
 
   return IAccessibleHolder(Move(intercepted));
 }
 
 IHandlerControlHolder