Bug 1455557: accept new line as RTCP FB NACK terminator. r=bwc draft
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Fri, 20 Apr 2018 21:52:16 -0700 (2018-04-21)
changeset 786108 97bca7eb56b1e112fc3ff091e58323ff1d09d43e
parent 785370 5d73549d363f2a52854ff43fabac9c6fd05b90b0
push id107394
push userdrno@ohlmeier.org
push dateSat, 21 Apr 2018 04:53:00 +0000 (2018-04-21)
reviewersbwc
bugs1455557
milestone61.0a1
Bug 1455557: accept new line as RTCP FB NACK terminator. r=bwc MozReview-Commit-ID: B0KaqRvLqNs
media/webrtc/signaling/src/sdp/sipcc/sdp_attr.c
--- a/media/webrtc/signaling/src/sdp/sipcc/sdp_attr.c
+++ b/media/webrtc/signaling/src/sdp/sipcc/sdp_attr.c
@@ -4674,17 +4674,17 @@ sdp_result_e sdp_parse_attr_rtcp_fb (sdp
 
         case SDP_RTCP_FB_NACK:
             /* Skip any remaining WS -- see
                http://code.google.com/p/webrtc/issues/detail?id=1922 */
             while (*ptr == ' ' || *ptr == '\t') {
                 ptr++;
             }
             /* Check for empty string */
-            if (*ptr == '\r') {
+            if (*ptr == '\r' || *ptr == '\n') {
                 rtcp_fb_p->param.nack = SDP_RTCP_FB_NACK_BASIC;
                 break;
             }
             i = find_token_enum("rtcp-fb nack type", sdp_p, &ptr,
                                 sdp_rtcp_fb_nack_type_val,
                                 SDP_MAX_RTCP_FB_NACK, SDP_RTCP_FB_NACK_UNKNOWN);
             if (i < 0) {
                 sdp_parse_error(sdp_p,