Bug 1455143 - Don't remove common test archive; r?Build draft
authorGregory Szorc <gps@mozilla.com>
Wed, 18 Apr 2018 17:34:25 -0700
changeset 785305 4025f33b4c2546d98f734a1acfb47a7b6f93790e
parent 785304 61f5322553405523028e09fbd8b48c826208e4da
child 785306 79cf490988a22bef21133b99dab84f1fa33b9aec
push id107184
push userbmo:gps@mozilla.com
push dateThu, 19 Apr 2018 21:22:59 +0000
reviewersBuild
bugs1455143
milestone61.0a1
Bug 1455143 - Don't remove common test archive; r?Build This target is a prereq for all test archives. Why we only remove a single test archive, I don't know. We always build this test archive. So it should always get overwritten and we don't need to remove an existing file. MozReview-Commit-ID: 1qd1T3w6kVT
testing/testsuite-targets.mk
--- a/testing/testsuite-targets.mk
+++ b/testing/testsuite-targets.mk
@@ -139,17 +139,16 @@ test-packages-manifest:
 	$(PYTHON) $(topsrcdir)/build/gen_test_packages_manifest.py \
       --jsshell $(JSSHELL_NAME) \
       --dest-file '$(MOZ_TEST_PACKAGES_FILE)' \
       $(call PKG_ARG,common,zip) \
       $(foreach pkg,$(TEST_PKGS_ZIP),$(call PKG_ARG,$(pkg),zip)) \
       $(foreach pkg,$(TEST_PKGS_TARGZ),$(call PKG_ARG,$(pkg),tar.gz))
 
 package-tests-prepare-dest:
-	@rm -f '$(DIST)/$(PKG_PATH)$(TEST_PACKAGE)'
 	$(NSINSTALL) -D $(DIST)/$(PKG_PATH)
 
 define package_archive
 package-tests-$(1): stage-all package-tests-prepare-dest
 	$$(call py_action,test_archive, \
 		$(1) \
 		'$$(abspath $$(DIST))/$$(PKG_PATH)/$$(PKG_BASENAME).$(1).tests.$(2)')
 package-tests: package-tests-$(1)