Bug 1455143 - Remove code for failing to obtain a hash; r?Build draft
authorGregory Szorc <gps@mozilla.com>
Wed, 18 Apr 2018 15:36:55 -0700
changeset 785301 02fe36000269a0a100bd7a5ca6fb6f32f3700dce
parent 785300 3bf7ce7764b4aaa32a9ddd01be70452664f63493
child 785302 9d6153d219fa39b3c9590dd9c86819d717adb6a1
push id107184
push userbmo:gps@mozilla.com
push dateThu, 19 Apr 2018 21:22:59 +0000
reviewersBuild
bugs1455143
milestone61.0a1
Bug 1455143 - Remove code for failing to obtain a hash; r?Build digest_file() should always return something. MozReview-Commit-ID: 6PpSUnxhCcL
build/checksums.py
--- a/build/checksums.py
+++ b/build/checksums.py
@@ -56,20 +56,17 @@ def process_files(files, output_filename
         logger.debug('Overwriting existing checksums file "%s"' %
                      output_filename)
     else:
         logger.debug('Creating a new checksums file "%s"' % output_filename)
     with open(output_filename, 'w+') as output:
         for file in files:
             for digest in digests:
                 hash = digest_file(file, digest)
-                if hash is None:
-                    logger.warn('Unable to generate a hash for %s. ' +
-                                'Skipping.' % file)
-                    continue
+
                 if file.startswith(strip):
                     short_file = file[len(strip):]
                     short_file = short_file.lstrip('/')
                 else:
                     short_file = file
                 print >>output, '%s %s %s %s' % (hash, digest,
                                                  os.path.getsize(file),
                                                  short_file)