Bug 1455143 - Remove hash name validation; r?Build draft
authorGregory Szorc <gps@mozilla.com>
Wed, 18 Apr 2018 15:31:59 -0700
changeset 785298 9f0b34908530f0afe00bd10cd490471ee4f41481
parent 785297 29667c2511ba963993cebfe2476456a41caf8311
child 785299 feb1ba3bbe0f5cb05925f176f0b191df5a7e9114
push id107184
push userbmo:gps@mozilla.com
push dateThu, 19 Apr 2018 21:22:59 +0000
reviewersBuild
bugs1455143
milestone61.0a1
Bug 1455143 - Remove hash name validation; r?Build Garbage in garbage out. Let's make this code simpler. MozReview-Commit-ID: Gv0ZcMacyOX
build/checksums.py
--- a/build/checksums.py
+++ b/build/checksums.py
@@ -127,23 +127,16 @@ def main():
 
     # Set up logging
     setup_logging(loglevel)
     logger = logging.getLogger('checksums.py')
 
     # Validate the digest type to use
     if not options.digests:
         options.digests = ['sha1']
-    try:
-        for digest in options.digests:
-            hashlib.new(digest)
-    except ValueError as ve:
-        logger.error('Could not create a "%s" hash object (%s)' %
-                     (digest, ve.args[0]))
-        exit(1)
 
     # Validate the files to checksum
     files = []
     for i in args:
         if os.path.exists(i):
             files.append(i)
         else:
             logger.info('File "%s" was not found on the filesystem' % i)