Bug 1432645 add browserSetting to flip urlbar.openintab, r?rpl
MozReview-Commit-ID: 6egB1yj6bkI
--- a/toolkit/components/extensions/parent/ext-browserSettings.js
+++ b/toolkit/components/extensions/parent/ext-browserSettings.js
@@ -164,16 +164,26 @@ ExtensionPreferencesManager.addSetting("
"browser.search.openintab",
],
setCallback(value) {
return {[this.prefNames[0]]: value};
},
});
+ExtensionPreferencesManager.addSetting("openUrlbarResultsInNewTabs", {
+ prefNames: [
+ "browser.urlbar.openintab",
+ ],
+
+ setCallback(value) {
+ return {[this.prefNames[0]]: value};
+ },
+});
+
ExtensionPreferencesManager.addSetting("proxyConfig", {
prefNames: [
"network.proxy.type",
"network.proxy.http",
"network.proxy.http_port",
"network.proxy.share_proxy_settings",
"network.proxy.ftp",
"network.proxy.ftp_port",
@@ -320,16 +330,21 @@ this.browserSettings = class extends Ext
() => {
return Services.prefs.getBoolPref("browser.tabs.loadBookmarksInTabs");
}),
openSearchResultsInNewTabs: getSettingsAPI(
extension, "openSearchResultsInNewTabs",
() => {
return Services.prefs.getBoolPref("browser.search.openintab");
}),
+ openUrlbarResultsInNewTabs: getSettingsAPI(
+ extension, "openUrlbarResultsInNewTabs",
+ () => {
+ return Services.prefs.getBoolPref("browser.urlbar.openintab");
+ }),
proxyConfig: Object.assign(
getSettingsAPI(
extension, "proxyConfig",
() => {
let prefValue = Services.prefs.getIntPref("network.proxy.type");
let proxyConfig = {
proxyType:
Array.from(
--- a/toolkit/components/extensions/schemas/browser_settings.json
+++ b/toolkit/components/extensions/schemas/browser_settings.json
@@ -144,16 +144,20 @@
"openBookmarksInNewTabs": {
"$ref": "types.Setting",
"description": "This boolean setting controls whether bookmarks are opened in the current tab or in a new tab."
},
"openSearchResultsInNewTabs": {
"$ref": "types.Setting",
"description": "This boolean setting controls whether search results are opened in the current tab or in a new tab."
},
+ "openUrlbarResultsInNewTabs": {
+ "$ref": "types.Setting",
+ "description": "This boolean setting controls whether urlbar results are opened in the current tab or in a new tab."
+ },
"proxyConfig": {
"$ref": "types.Setting",
"description": "Configures proxy settings. This setting's value is an object of type ProxyConfig."
},
"webNotificationsDisabled": {
"$ref": "types.Setting",
"description": "Disables webAPI notifications."
},
--- a/toolkit/components/extensions/test/xpcshell/test_ext_browserSettings.js
+++ b/toolkit/components/extensions/test/xpcshell/test_ext_browserSettings.js
@@ -206,16 +206,23 @@ add_task(async function test_browser_set
await testSetting(
"openSearchResultsInNewTabs", true,
{"browser.search.openintab": true});
await testSetting(
"openSearchResultsInNewTabs", false,
{"browser.search.openintab": false});
await testSetting(
+ "openUrlbarResultsInNewTabs", true,
+ {"browser.urlbar.openintab": true});
+ await testSetting(
+ "openUrlbarResultsInNewTabs", false,
+ {"browser.urlbar.openintab": false});
+
+ await testSetting(
"overrideDocumentColors", "high-contrast-only",
{"browser.display.document_color_use": 0});
await testSetting(
"overrideDocumentColors", "never",
{"browser.display.document_color_use": 1});
await testSetting(
"overrideDocumentColors", "always",
{"browser.display.document_color_use": 2});