Bug 1455075 - handle a null argument in ContentParent::RecvShowAlert; r?mystor draft
authorAlex Gaynor <agaynor@mozilla.com>
Wed, 18 Apr 2018 14:53:43 -0400
changeset 784523 0686e06f0c1c6c05174d9ac9a6eefb2aa09c72ea
parent 784477 6480454995dae4a44c86887f4ae01dc998edb36f
push id106957
push userbmo:agaynor@mozilla.com
push dateWed, 18 Apr 2018 18:54:56 +0000
reviewersmystor
bugs1455075
milestone61.0a1
Bug 1455075 - handle a null argument in ContentParent::RecvShowAlert; r?mystor MozReview-Commit-ID: Be6D1fOe0w3
dom/ipc/ContentParent.cpp
--- a/dom/ipc/ContentParent.cpp
+++ b/dom/ipc/ContentParent.cpp
@@ -3703,16 +3703,19 @@ bool
 ContentParent::HasNotificationPermission(const IPC::Principal& aPrincipal)
 {
   return true;
 }
 
 mozilla::ipc::IPCResult
 ContentParent::RecvShowAlert(nsIAlertNotification* aAlert)
 {
+  if (!aAlert) {
+    return IPC_FAIL_NO_REASON(this);
+  }
   nsCOMPtr<nsIPrincipal> principal;
   nsresult rv = aAlert->GetPrincipal(getter_AddRefs(principal));
   if (NS_WARN_IF(NS_FAILED(rv)) ||
       !HasNotificationPermission(IPC::Principal(principal))) {
 
       return IPC_OK();
   }