Bug 1454876 - Make it possible to compile Firefox without Marionette. r?Gijs,maja_zf draft
authorAndreas Tolfsen <ato@sny.no>
Wed, 18 Apr 2018 08:10:21 +0100
changeset 784148 8335f98b8ee6b099f07e3b4ac4dfb8aba29cea33
parent 784147 c90379400a5b7fd034e7321a0153f43e8b53e3cd
child 784149 9571a17955d130a3171656b4717b65182d0df6d7
child 784235 aea2d19bf59f55b7c24483871eef7283398c2a1f
push id106864
push userbmo:ato@sny.no
push dateWed, 18 Apr 2018 07:24:46 +0000
reviewersGijs, maja_zf
bugs1454876
milestone61.0a1
Bug 1454876 - Make it possible to compile Firefox without Marionette. r?Gijs,maja_zf Marionette is only built when ENABLE_MARIONETTE is defined, but we unconditionally include its resources in Firefox' packaging instructions. These resources ought to be guarded with the same rule to actually make it possible to disable Marionette without breaking the packaging. We already do this on Fennec, see mobile/android/installer/package-manifest.in:373. MozReview-Commit-ID: 3s8e9sk6KGx
browser/installer/package-manifest.in
--- a/browser/installer/package-manifest.in
+++ b/browser/installer/package-manifest.in
@@ -325,20 +325,24 @@
 @RESPATH@/components/SlowScriptDebug.manifest
 @RESPATH@/components/SlowScriptDebug.js
 
 #ifdef MOZ_WEBRTC
 @RESPATH@/components/PeerConnection.js
 @RESPATH@/components/PeerConnection.manifest
 #endif
 
+; Remote control protocol
+#ifdef ENABLE_MARIONETTE
 @RESPATH@/chrome/marionette@JAREXT@
 @RESPATH@/chrome/marionette.manifest
 @RESPATH@/components/marionette.manifest
 @RESPATH@/components/marionette.js
+@RESPATH@/defaults/pref/marionette.js
+#endif
 
 @RESPATH@/components/nsAsyncShutdown.manifest
 @RESPATH@/components/nsAsyncShutdown.js
 
 @RESPATH@/components/BuiltinProviders.manifest
 @RESPATH@/components/PresentationControlService.js
 @RESPATH@/components/PresentationDataChannelSessionTransport.js
 @RESPATH@/components/PresentationDataChannelSessionTransport.manifest
@@ -451,20 +455,16 @@
 @RESPATH@/browser/defaults/blocklists
 @RESPATH@/browser/defaults/pinning
 
 ; Warning: changing the path to channel-prefs.js can cause bugs (Bug 756325)
 ; Technically this is an app pref file, but we are keeping it in the original
 ; gre location for now.
 @RESPATH@/defaults/pref/channel-prefs.js
 
-; Remote control protocol prefs
-; defined in ../../testing/marionette/prefs/marionette.js
-@RESPATH@/defaults/pref/marionette.js
-
 ; Services (gre) prefs
 @RESPATH@/defaults/pref/services-sync.js
 
 ; [Layout Engine Resources]
 ; Style Sheets, Graphics and other Resources used by the layout engine.
 @RESPATH@/res/EditorOverride.css
 @RESPATH@/res/contenteditable.css
 @RESPATH@/res/designmode.css