Bug 1453568 - Rewrite css-transitions/test_event-dispatch.html with async/await. r?birtles draft
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Tue, 17 Apr 2018 08:28:59 +0900
changeset 783345 ad337754a0a7a8ed14cc7abe3f5e95cb7b37e2b9
parent 783344 dfcc193e8bb4051a0fe90d63ecc12b4fd371e9bc
child 783346 8f03db3db2ed66e570a5450b914787a921ec3330
push id106674
push userhikezoe@mozilla.com
push dateTue, 17 Apr 2018 01:36:18 +0000
reviewersbirtles
bugs1453568
milestone61.0a1
Bug 1453568 - Rewrite css-transitions/test_event-dispatch.html with async/await. r?birtles MozReview-Commit-ID: L8OPhttwpbq
dom/animation/test/css-transitions/test_event-dispatch.html
--- a/dom/animation/test/css-transitions/test_event-dispatch.html
+++ b/dom/animation/test/css-transitions/test_event-dispatch.html
@@ -54,423 +54,357 @@ function setupTransition(t, transitionSt
   div.style.marginLeft = '100px';
   const transition = div.getAnimations()[0];
 
   return { transition, watcher, div, handler };
 }
 
 // On the next frame (i.e. when events are queued), whether or not the
 // transition is still pending depends on the implementation.
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher } =
     setupTransition(t, 'margin-left 100s 100s');
-  return watcher.wait_for('transitionrun').then(evt => {
-    assert_equals(evt.elapsedTime, 0.0);
-  });
+  const event = await watcher.wait_for('transitionrun');
+  assert_equals(event.elapsedTime, 0.0);
 }, 'Idle -> Pending or Before');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher } =
     setupTransition(t, 'margin-left 100s 100s');
   // Force the transition to leave the idle phase
   transition.startTime = document.timeline.currentTime;
-  return watcher.wait_for('transitionrun').then(evt => {
-    assert_equals(evt.elapsedTime, 0.0);
-  });
+  const event = await watcher.wait_for('transitionrun');
+  assert_equals(event.elapsedTime, 0.0);
 }, 'Idle -> Before');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div, handler } =
     setupTransition(t, 'margin-left 100s 100s');
 
   // Seek to Active phase.
   transition.currentTime = 100 * MS_PER_SEC;
   transition.pause();
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(evt => {
-    assert_equals(handler.transitionrun, 0.0);
-    assert_equals(handler.transitionstart, 0.0);
-  });
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  assert_equals(handler.transitionrun, 0.0);
+  assert_equals(handler.transitionstart, 0.0);
 }, 'Idle or Pending -> Active');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div, handler } =
     setupTransition(t, 'margin-left 100s 100s');
 
   // Seek to After phase.
   transition.finish();
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart',
-                            'transitionend' ]).then(evt => {
-    assert_equals(handler.transitionrun, 0.0);
-    assert_equals(handler.transitionstart, 0.0);
-    assert_equals(handler.transitionend, 100.0);
-  });
+  await watcher.wait_for([ 'transitionrun',
+                           'transitionstart',
+                           'transitionend' ]);
+  assert_equals(handler.transitionrun, 0.0);
+  assert_equals(handler.transitionstart, 0.0);
+  assert_equals(handler.transitionend, 100.0);
 }, 'Idle or Pending -> After');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div } =
     setupTransition(t, 'margin-left 100s 100s');
 
-  return Promise.all([ watcher.wait_for('transitionrun'),
-                       transition.ready ]).then(() => {
-    // Make idle
-    div.style.display = 'none';
-    flushComputedStyle(div);
-    return watcher.wait_for('transitioncancel');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 0.0);
-  });
+  await Promise.all([ watcher.wait_for('transitionrun'), transition.ready ]);
+  // Make idle
+  div.style.display = 'none';
+  flushComputedStyle(div);
+  const event = await watcher.wait_for('transitioncancel');
+  assert_equals(event.elapsedTime, 0.0);
 }, 'Before -> Idle (display: none)');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher } =
     setupTransition(t, 'margin-left 100s 100s');
 
-  return Promise.all([ watcher.wait_for('transitionrun'),
-                       transition.ready ]).then(() => {
-    // Make idle
-    transition.timeline = null;
-    return watcher.wait_for('transitioncancel');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 0.0);
-  });
+  await Promise.all([ watcher.wait_for('transitionrun'), transition.ready ]);
+  // Make idle
+  transition.timeline = null;
+  const event = await watcher.wait_for('transitioncancel');
+  assert_equals(event.elapsedTime, 0.0);
 }, 'Before -> Idle (Animation.timeline = null)');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher } =
     setupTransition(t, 'margin-left 100s 100s');
 
-  return Promise.all([ watcher.wait_for('transitionrun'),
-                       transition.ready ]).then(() => {
-    transition.currentTime = 100 * MS_PER_SEC;
-    return watcher.wait_for('transitionstart');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 0.0);
-  });
+  await Promise.all([ watcher.wait_for('transitionrun'), transition.ready ]);
+  transition.currentTime = 100 * MS_PER_SEC;
+  const event = await watcher.wait_for('transitionstart');
+  assert_equals(event.elapsedTime, 0.0);
 }, 'Before -> Active');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div, handler } =
     setupTransition(t, 'margin-left 100s 100s');
 
-  return Promise.all([ watcher.wait_for('transitionrun'),
-                       transition.ready ]).then(() => {
-    // Seek to After phase.
-    transition.currentTime = 200 * MS_PER_SEC;
-    return watcher.wait_for([ 'transitionstart', 'transitionend' ]);
-  }).then(evt => {
-    assert_equals(handler.transitionstart, 0.0);
-    assert_equals(handler.transitionend, 100.0);
-  });
+  await Promise.all([ watcher.wait_for('transitionrun'), transition.ready ]);
+  // Seek to After phase.
+  transition.currentTime = 200 * MS_PER_SEC;
+  await watcher.wait_for([ 'transitionstart', 'transitionend' ]);
+  assert_equals(handler.transitionstart, 0.0);
+  assert_equals(handler.transitionend, 100.0);
 }, 'Before -> After');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div } =
     setupTransition(t, 'margin-left 100s');
 
   // Seek to Active start position.
   transition.pause();
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(evt => {
-    // Make idle
-    div.style.display = 'none';
-    flushComputedStyle(div);
-    return watcher.wait_for('transitioncancel');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 0.0);
-  });
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  // Make idle
+  div.style.display = 'none';
+  flushComputedStyle(div);
+  const event = await watcher.wait_for('transitioncancel');
+  assert_equals(event.elapsedTime, 0.0);
 }, 'Active -> Idle, no delay (display: none)');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher } =
     setupTransition(t, 'margin-left 100s');
 
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(evt => {
-    // Make idle
-    transition.currentTime = 0;
-    transition.timeline = null;
-    return watcher.wait_for('transitioncancel');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 0.0);
-  });
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  // Make idle
+  transition.currentTime = 0;
+  transition.timeline = null;
+  const event = await watcher.wait_for('transitioncancel');
+  assert_equals(event.elapsedTime, 0.0);
 }, 'Active -> Idle, no delay (Animation.timeline = null)');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div } =
     setupTransition(t, 'margin-left 100s 100s');
   // Pause so the currentTime is fixed and we can accurately compare the event
   // time in transition cancel events.
   transition.pause();
 
   // Seek to Active phase.
   transition.currentTime = 100 * MS_PER_SEC;
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(evt => {
-    // Make idle
-    div.style.display = 'none';
-    flushComputedStyle(div);
-    return watcher.wait_for('transitioncancel');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 0.0);
-  });
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  // Make idle
+  div.style.display = 'none';
+  flushComputedStyle(div);
+  const event = await watcher.wait_for('transitioncancel');
+  assert_equals(event.elapsedTime, 0.0);
 }, 'Active -> Idle, with positive delay (display: none)');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher } =
     setupTransition(t, 'margin-left 100s 100s');
 
   // Seek to Active phase.
   transition.currentTime = 100 * MS_PER_SEC;
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(evt => {
-    // Make idle
-    transition.currentTime = 100 * MS_PER_SEC;
-    transition.timeline = null;
-    return watcher.wait_for('transitioncancel');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 0.0);
-  });
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  // Make idle
+  transition.currentTime = 100 * MS_PER_SEC;
+  transition.timeline = null;
+  const event = await watcher.wait_for('transitioncancel');
+  assert_equals(event.elapsedTime, 0.0);
 }, 'Active -> Idle, with positive delay (Animation.timeline = null)');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div } =
     setupTransition(t, 'margin-left 100s -50s');
 
   // Pause so the currentTime is fixed and we can accurately compare the event
   // time in transition cancel events.
   transition.pause();
 
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(evt => {
-    // Make idle
-    div.style.display = 'none';
-    flushComputedStyle(div);
-    return watcher.wait_for('transitioncancel');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 50.0);
-  });
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  // Make idle
+  div.style.display = 'none';
+  flushComputedStyle(div);
+  const event = await watcher.wait_for('transitioncancel');
+  assert_equals(event.elapsedTime, 50.0);
 }, 'Active -> Idle, with negative delay (display: none)');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher } =
     setupTransition(t, 'margin-left 100s -50s');
 
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(evt => {
-    // Make idle
-    transition.currentTime = 50 * MS_PER_SEC;
-    transition.timeline = null;
-    return watcher.wait_for('transitioncancel');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 0.0);
-  });
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  // Make idle
+  transition.currentTime = 50 * MS_PER_SEC;
+  transition.timeline = null;
+  const event = await watcher.wait_for('transitioncancel');
+  assert_equals(event.elapsedTime, 0.0);
 }, 'Active -> Idle, with negative delay (Animation.timeline = null)');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher } =
     setupTransition(t, 'margin-left 100s 100s');
   // Seek to Active phase.
   transition.currentTime = 100 * MS_PER_SEC;
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(evt => {
-    // Seek to Before phase.
-    transition.currentTime = 0;
-    return watcher.wait_for('transitionend');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 0.0);
-  });
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  // Seek to Before phase.
+  transition.currentTime = 0;
+  const event = await watcher.wait_for('transitionend');
+  assert_equals(event.elapsedTime, 0.0);
 }, 'Active -> Before');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher } =
     setupTransition(t, 'margin-left 100s 100s');
   // Seek to Active phase.
   transition.currentTime = 100 * MS_PER_SEC;
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(evt => {
-    // Seek to After phase.
-    transition.currentTime = 200 * MS_PER_SEC;
-    return watcher.wait_for('transitionend');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 100.0);
-  });
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  // Seek to After phase.
+  transition.currentTime = 200 * MS_PER_SEC;
+  const event = await watcher.wait_for('transitionend');
+  assert_equals(event.elapsedTime, 100.0);
 }, 'Active -> After');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div, handler } =
     setupTransition(t, 'margin-left 100s 100s');
 
   // Seek to After phase.
   transition.finish();
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart',
-                            'transitionend' ]).then(evt => {
-    // Seek to Before phase.
-    transition.currentTime = 0;
-    return watcher.wait_for([ 'transitionstart', 'transitionend' ]);
-  }).then(evt => {
-    assert_equals(handler.transitionstart, 100.0);
-    assert_equals(handler.transitionend, 0.0);
-  });
+  await watcher.wait_for([ 'transitionrun',
+                           'transitionstart',
+                           'transitionend' ]);
+  // Seek to Before phase.
+  transition.currentTime = 0;
+  await watcher.wait_for([ 'transitionstart', 'transitionend' ]);
+  assert_equals(handler.transitionstart, 100.0);
+  assert_equals(handler.transitionend, 0.0);
 }, 'After -> Before');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher } =
     setupTransition(t, 'margin-left 100s 100s');
   // Seek to After phase.
   transition.finish();
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart',
-                            'transitionend' ]).then(evt => {
-    // Seek to Active phase.
-    transition.currentTime = 100 * MS_PER_SEC;
-    return watcher.wait_for('transitionstart');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 100.0);
-  });
+  await watcher.wait_for([ 'transitionrun',
+                           'transitionstart',
+                           'transitionend' ]);
+  // Seek to Active phase.
+  transition.currentTime = 100 * MS_PER_SEC;
+  const event = await watcher.wait_for('transitionstart');
+  assert_equals(event.elapsedTime, 100.0);
 }, 'After -> Active');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div, handler } =
     setupTransition(t, 'margin-left 100s -50s');
 
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(() => {
-    assert_equals(handler.transitionrun, 50.0);
-    assert_equals(handler.transitionstart, 50.0);
-    transition.finish();
-    return watcher.wait_for('transitionend');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 100.0);
-  });
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  assert_equals(handler.transitionrun, 50.0);
+  assert_equals(handler.transitionstart, 50.0);
+  transition.finish();
+  const event = await watcher.wait_for('transitionend');
+  assert_equals(event.elapsedTime, 100.0);
 }, 'Calculating the interval start and end time with negative start delay.');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div, handler } =
     setupTransition(t, 'margin-left 100s 100s');
 
-  return watcher.wait_for('transitionrun').then(evt => {
-    // We can't set the end delay via generated effect timing.
-    // Because CSS-Transition use the AnimationEffectTimingReadOnly.
-    transition.effect = new KeyframeEffect(div,
-                                           { marginleft: [ '0px', '100px' ]},
-                                           { duration: 100 * MS_PER_SEC,
-                                             endDelay: -50 * MS_PER_SEC });
-    // Seek to Before and play.
-    transition.cancel();
-    transition.play();
-    return watcher.wait_for([ 'transitioncancel',
-                              'transitionrun',
-                              'transitionstart' ]);
-  }).then(() => {
-    assert_equals(handler.transitionstart, 0.0);
+  await watcher.wait_for('transitionrun');
+  // We can't set the end delay via generated effect timing.
+  // Because CSS-Transition use the AnimationEffectTimingReadOnly.
+  transition.effect = new KeyframeEffect(div,
+                                         { marginleft: [ '0px', '100px' ]},
+                                         { duration: 100 * MS_PER_SEC,
+                                           endDelay: -50 * MS_PER_SEC });
+  // Seek to Before and play.
+  transition.cancel();
+  transition.play();
+  await watcher.wait_for([ 'transitioncancel',
+                           'transitionrun',
+                           'transitionstart' ]);
+  assert_equals(handler.transitionstart, 0.0);
 
-    // Seek to After phase.
-    transition.finish();
-    return watcher.wait_for('transitionend');
-  }).then(evt => {
-    assert_equals(evt.elapsedTime, 50.0);
-  });
+  // Seek to After phase.
+  transition.finish();
+  const event = await watcher.wait_for('transitionend');
+  assert_equals(event.elapsedTime, 50.0);
 }, 'Calculating the interval start and end time with negative end delay.');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div } =
     setupTransition(t, 'margin-left 100s 100s');
 
-  return watcher.wait_for('transitionrun').then(() => {
-    // Make idle
-    div.style.display = 'none';
-    flushComputedStyle(div);
-    return watcher.wait_for('transitioncancel');
-  }).then(() => {
-    transition.cancel();
-    // Then wait a couple of frames and check that no event was dispatched
-    return waitForAnimationFrames(2);
-  });
+  await watcher.wait_for('transitionrun');
+  // Make idle
+  div.style.display = 'none';
+  flushComputedStyle(div);
+  await watcher.wait_for('transitioncancel');
+  transition.cancel();
+  // Then wait a couple of frames and check that no event was dispatched
+  await waitForAnimationFrames(2);
 }, 'Call Animation.cancel after cancelling transition.');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div } =
     setupTransition(t, 'margin-left 100s 100s');
 
-  return watcher.wait_for('transitionrun').then(evt => {
-    // Make idle
-    div.style.display = 'none';
-    flushComputedStyle(div);
-    transition.play();
-    return watcher.wait_for('transitioncancel');
-  }).then(() => {
-    return waitForAnimationFrames(2);
-  });
+  await watcher.wait_for('transitionrun');
+  // Make idle
+  div.style.display = 'none';
+  flushComputedStyle(div);
+  transition.play();
+  await watcher.wait_for('transitioncancel');
+  await waitForAnimationFrames(2);
 }, 'Restart transition after cancelling transition immediately');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div } =
     setupTransition(t, 'margin-left 100s 100s');
 
-  return watcher.wait_for('transitionrun').then(evt => {
-    // Make idle
-    div.style.display = 'none';
-    flushComputedStyle(div);
-    transition.play();
-    transition.cancel();
-    return watcher.wait_for('transitioncancel');
-  }).then(evt => {
-    // Then wait a couple of frames and check that no event was dispatched
-    return waitForAnimationFrames(2);
-  });
+  await watcher.wait_for('transitionrun');
+  // Make idle
+  div.style.display = 'none';
+  flushComputedStyle(div);
+  transition.play();
+  transition.cancel();
+  await watcher.wait_for('transitioncancel');
+  // Then wait a couple of frames and check that no event was dispatched
+  await waitForAnimationFrames(2);
 }, 'Call Animation.cancel after restarting transition immediately');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher } =
     setupTransition(t, 'margin-left 100s');
 
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(evt => {
-    // Make idle
-    transition.timeline = null;
-    return watcher.wait_for('transitioncancel');
-  }).then(evt => {
-    transition.timeline = document.timeline;
-    transition.play();
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  // Make idle
+  transition.timeline = null;
+  await watcher.wait_for('transitioncancel');
+  transition.timeline = document.timeline;
+  transition.play();
 
-    return watcher.wait_for(['transitionrun', 'transitionstart']);
-  });
+  await watcher.wait_for(['transitionrun', 'transitionstart']);
 }, 'Set timeline and play transition after clear the timeline');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div } =
     setupTransition(t, 'margin-left 100s');
 
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(() => {
-    transition.cancel();
-    return watcher.wait_for('transitioncancel');
-  }).then(() => {
-    // Make After phase
-    transition.effect = null;
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  transition.cancel();
+  await watcher.wait_for('transitioncancel');
+  // Make After phase
+  transition.effect = null;
 
-    // Then wait a couple of frames and check that no event was dispatched
-    return waitForAnimationFrames(2);
-  });
+  // Then wait a couple of frames and check that no event was dispatched
+  await waitForAnimationFrames(2);
 }, 'Set null target effect after cancel the transition');
 
-promise_test(t => {
+promise_test(async t => {
   const { transition, watcher, div } =
     setupTransition(t, 'margin-left 100s');
 
-  return watcher.wait_for([ 'transitionrun',
-                            'transitionstart' ]).then(evt => {
-    transition.effect = null;
-    return watcher.wait_for('transitionend');
-  }).then(evt => {
-    transition.cancel();
+  await watcher.wait_for([ 'transitionrun', 'transitionstart' ]);
+  transition.effect = null;
+  await watcher.wait_for('transitionend');
+  transition.cancel();
 
-    // Then wait a couple of frames and check that no event was dispatched
-    return waitForAnimationFrames(2);
-  });
+  // Then wait a couple of frames and check that no event was dispatched
+  await waitForAnimationFrames(2);
 }, 'Cancel the transition after clearing the target effect');
 
 </script>
 </body>
 </html>