Bug 1453876: Fix accessibility blocking of the Ask.com Toolbar. r?eeejay draft
authorJames Teh <jteh@mozilla.com>
Fri, 13 Apr 2018 15:12:13 +1000
changeset 781554 f3089747159876e158d0aa3270c2bc59b91951a6
parent 781489 da809ecceaf3a8ada0aa2d7115822d39d0439654
push id106336
push userbmo:jteh@mozilla.com
push dateFri, 13 Apr 2018 05:16:05 +0000
reviewerseeejay
bugs1453876, 1421018
milestone61.0a1
Bug 1453876: Fix accessibility blocking of the Ask.com Toolbar. r?eeejay Bug 1421018 intended to block the Ask.Com Toolbar (tbnotifier.exe). This is basically malware and is responsible for a huge number of unnecessary accessibility instantiations. However, there seems to have been some confusion and we ended up blocking tbnnotifier.exe instead. This changes that block to tbnotifier.exe. MozReview-Commit-ID: 2gZF8sYeGtb
accessible/windows/msaa/LazyInstantiator.cpp
--- a/accessible/windows/msaa/LazyInstantiator.cpp
+++ b/accessible/windows/msaa/LazyInstantiator.cpp
@@ -190,17 +190,17 @@ static const DllBlockInfo gBlockedInproc
   {L"dtvhooks.dll", MAKE_FILE_VERSION(18, 1, 11, 0)},
   {L"dtvhooks64.dll", MAKE_FILE_VERSION(18, 1, 11, 0)}
 };
 
 /**
  * This is the blocklist for known "bad" remote clients that instantiate a11y.
  */
 static const char* gBlockedRemoteClients[] = {
-  "tbnnotifier.exe" // Ask.com Toolbar, bug 1421018
+  "tbnotifier.exe" // Ask.com Toolbar, bug 1453876
 };
 
 /**
  * Check for the presence of any known "bad" injected DLLs that may be trying
  * to instantiate a11y.
  *
  * @return true to block a11y instantiation, otherwise false to continue
  */