bug 1353296 - get rid of filter_upload_symbols. r?dustin
filter_upload_symbols is a relic of task configurations that were written
before we had a better handle on taskgraph generation. We should only be
uploading symbols for nightly builds anyway, so this is better served using
newer filtering methods.
upload-symbols tasks were specified to run on non-nightly build types in the
kind.yml, but those were filtered out in filter_upload_symbols. I believe
these were simply an artifact of the initial upload-symbols implementation
happening before nightly builds were running in Taskcluster.
MozReview-Commit-ID: Je1NytrVPT8
--- a/taskcluster/ci/upload-symbols/kind.yml
+++ b/taskcluster/ci/upload-symbols/kind.yml
@@ -7,35 +7,18 @@ loader: taskgraph.loader.single_dep:load
transforms:
- taskgraph.transforms.upload_symbols:transforms
- taskgraph.transforms.job:transforms
- taskgraph.transforms.task:transforms
kind-dependencies:
- build
-only-for-build-platforms:
- - linux64/opt
- - linux64/debug
- - linux64-nightly/opt
- - linux-nightly/opt
- - linux64-devedition-nightly/opt
- - linux-devedition-nightly/opt
- - android-aarch64-nightly/opt
- - android-api-16/opt
- - android-api-16-nightly/opt
- - android-api-16-old-id-nightly/opt
- - android-x86-nightly/opt
- - android-x86-old-id-nightly/opt
- - macosx64-nightly/opt
- - macosx64-devedition-nightly/opt
- - win32-nightly/opt
- - win64-nightly/opt
- - win32-devedition-nightly/opt
- - win64-devedition-nightly/opt
+only-for-attributes:
+ - nightly
job-template:
description: Upload Symbols
worker-type: aws-provisioner-v1/gecko-{level}-b-linux
worker:
docker-image: {in-tree: "lint"}
max-run-time: 900
env:
--- a/taskcluster/taskgraph/target_tasks.py
+++ b/taskcluster/taskgraph/target_tasks.py
@@ -28,25 +28,16 @@ def filter_on_nightly(task, parameters):
return not task.attributes.get('nightly') or parameters.get('include_nightly')
def filter_for_project(task, parameters):
"""Filter tasks by project. Optionally enable nightlies."""
run_on_projects = set(task.attributes.get('run_on_projects', []))
return match_run_on_projects(parameters['project'], run_on_projects)
-
-def filter_upload_symbols(task, parameters):
- # Filters out symbols when there are not part of a nightly or a release build
- # TODO Remove this too specific filter (bug 1353296)
- return '-upload-symbols' not in task.label or \
- task.attributes.get('nightly') or \
- parameters.get('project') in ('mozilla-beta', 'mozilla-release')
-
-
def filter_beta_release_tasks(task, parameters, ignore_kinds=None, allow_l10n=False):
if not standard_filter(task, parameters):
return False
if ignore_kinds is None:
ignore_kinds = [
'balrog',
'beetmover', 'beetmover-checksums', 'beetmover-l10n',
'beetmover-repackage', 'beetmover-repackage-signing',
@@ -83,17 +74,17 @@ def filter_beta_release_tasks(task, para
return False
return True
def standard_filter(task, parameters):
return all(
filter_func(task, parameters) for filter_func in
- (filter_on_nightly, filter_for_project, filter_upload_symbols)
+ (filter_on_nightly, filter_for_project)
)
def _try_task_config(full_task_graph, parameters, graph_config):
requested_tasks = parameters['try_task_config']['tasks']
return list(set(requested_tasks) & full_task_graph.graph.nodes)
