Bug 645325 - Part 3: Remove nsGeoPosition's unused `long long aTimestamp` constructor. r=garvank r?jdm
And change nsGeoPosition to store DOMTimeStamp instead of long long because it is a more descriptive type. DOMTimeStamp is a typedef for uint64_t, so we're not losing any precision using DOMTimeStamp instead of long long.
MozReview-Commit-ID: hjXnw959yC
--- a/dom/geolocation/nsGeoPosition.cpp
+++ b/dom/geolocation/nsGeoPosition.cpp
@@ -124,33 +124,26 @@ nsGeoPositionCoords::GetSpeed(double *aS
////////////////////////////////////////////////////
// nsGeoPosition
////////////////////////////////////////////////////
nsGeoPosition::nsGeoPosition(double aLat, double aLong,
double aAlt, double aHError,
double aVError, double aHeading,
- double aSpeed, long long aTimestamp) :
+ double aSpeed, DOMTimeStamp aTimestamp) :
mTimestamp(aTimestamp)
{
mCoords = new nsGeoPositionCoords(aLat, aLong,
aAlt, aHError,
aVError, aHeading,
aSpeed);
}
nsGeoPosition::nsGeoPosition(nsIDOMGeoPositionCoords *aCoords,
- long long aTimestamp) :
- mTimestamp(aTimestamp),
- mCoords(aCoords)
-{
-}
-
-nsGeoPosition::nsGeoPosition(nsIDOMGeoPositionCoords *aCoords,
DOMTimeStamp aTimestamp) :
mTimestamp(aTimestamp),
mCoords(aCoords)
{
}
nsGeoPosition::~nsGeoPosition()
{
--- a/dom/geolocation/nsGeoPosition.h
+++ b/dom/geolocation/nsGeoPosition.h
@@ -47,28 +47,24 @@ class nsGeoPosition final : public nsIDO
{
public:
NS_DECL_THREADSAFE_ISUPPORTS
NS_DECL_NSIDOMGEOPOSITION
nsGeoPosition(double aLat, double aLong,
double aAlt, double aHError,
double aVError, double aHeading,
- double aSpeed, long long aTimestamp);
-
-
- nsGeoPosition(nsIDOMGeoPositionCoords *aCoords,
- long long aTimestamp);
+ double aSpeed, DOMTimeStamp aTimestamp);
nsGeoPosition(nsIDOMGeoPositionCoords *aCoords,
DOMTimeStamp aTimestamp);
private:
~nsGeoPosition();
- long long mTimestamp;
+ DOMTimeStamp mTimestamp;
RefPtr<nsIDOMGeoPositionCoords> mCoords;
};
////////////////////////////////////////////////////
// WebIDL wrappers for the classes above
////////////////////////////////////////////////////
namespace mozilla {