Bug 1450017 - Part IV, Always set resizer direction explicitly in ScrollFrameHelper::CreateAnonymousContent() draft
authorTimothy Guan-tin Chien <timdream@gmail.com>
Tue, 10 Apr 2018 21:10:29 +0800
changeset 788003 c8230db29d175e372eceade1ed73bc4c8c6197f8
parent 788002 fc8057d5cc848c3124984d0e57b704b8e2b7a04f
child 788004 911890504cebc8913a01e14b52f181088a34764e
push id107872
push usertimdream@gmail.com
push dateWed, 25 Apr 2018 20:44:34 +0000
bugs1450017
milestone61.0a1
Bug 1450017 - Part IV, Always set resizer direction explicitly in ScrollFrameHelper::CreateAnonymousContent() Given that we have access to the RTL/writing modes information via ScrollFrameHelper::IsPhysicalLTR(), set the dir to bottomleft/bottomright instead of context-aware value bottomend. MozReview-Commit-ID: Lfe053WOsY2
layout/generic/nsGfxScrollFrame.cpp
--- a/layout/generic/nsGfxScrollFrame.cpp
+++ b/layout/generic/nsGfxScrollFrame.cpp
@@ -4704,17 +4704,22 @@ ScrollFrameHelper::CreateAnonymousConten
         else {
           dir.AssignLiteral("left");
         }
         break;
       case NS_STYLE_RESIZE_VERTICAL:
         dir.AssignLiteral("bottom");
         break;
       case NS_STYLE_RESIZE_BOTH:
-        dir.AssignLiteral("bottomend");
+        if (IsScrollbarOnRight()) {
+          dir.AssignLiteral("bottomright");
+        }
+        else {
+          dir.AssignLiteral("bottomleft");
+        }
         break;
       default:
         NS_WARNING("only resizable types should have resizers");
     }
     mResizerContent->SetAttr(kNameSpaceID_None, nsGkAtoms::dir, dir, false);
 
     if (mIsRoot) {
       mResizerContent->SetProperty(nsGkAtoms::docLevelNativeAnonymousContent,