bug 1328964 add override to ~WorkletJSContext/Runtime and use = default r?baku draft
authorKarl Tomlinson <karlt+@karlt.net>
Tue, 27 Mar 2018 18:15:54 +1300
changeset 780860 0dd362f0b328fee755b07372f1d8a1df41dce1af
parent 780859 9f75cdf217142a2f54930a1d4ac1f70c4d70dbbb
child 780861 e443ea752776949f9b32faceec79f2510ea2b5b6
push id106145
push userktomlinson@mozilla.com
push dateThu, 12 Apr 2018 05:09:40 +0000
reviewersbaku
bugs1328964
milestone61.0a1
bug 1328964 add override to ~WorkletJSContext/Runtime and use = default r?baku Addresses modernize-use-override and modernize-use-equals-default clang-tidy suggestions in "part 2 - Worklet Thread". MozReview-Commit-ID: H1a9kBCF1Q6
dom/worklet/WorkletThread.cpp
--- a/dom/worklet/WorkletThread.cpp
+++ b/dom/worklet/WorkletThread.cpp
@@ -105,19 +105,17 @@ const JSWrapObjectCallbacks WrapObjectCa
 class WorkletJSRuntime final : public mozilla::CycleCollectedJSRuntime
 {
 public:
   explicit WorkletJSRuntime(JSContext* aCx)
     : CycleCollectedJSRuntime(aCx)
   {
   }
 
-  ~WorkletJSRuntime()
-  {
-  }
+  ~WorkletJSRuntime() override = default;
 
   virtual void
   PrepareForForgetSkippable() override
   {
   }
 
   virtual void
   BeginCycleCollectionCallback() override
@@ -152,17 +150,17 @@ public:
     : mWorkletThread(aWorkletThread)
   {
     MOZ_ASSERT(aWorkletThread);
     MOZ_ASSERT(!NS_IsMainThread());
 
     nsCycleCollector_startup();
   }
 
-  ~WorkletJSContext()
+  ~WorkletJSContext() override
   {
     MOZ_ASSERT(!NS_IsMainThread());
 
     JSContext* cx = MaybeContext();
     if (!cx) {
       return;   // Initialize() must have failed
     }