Bug 1452483 - Set correct line number for JS evaluation. r?maja_zf draft
authorAndreas Tolfsen <ato@sny.no>
Sun, 08 Apr 2018 17:44:55 +0100 (2018-04-08)
changeset 780424 bcb03dbd162888273a969342aae0fd375750b441
parent 780394 f6c3a0a19d82db25750d8badccd5cf37e79d028e
child 780425 d3194be79b21cf1251ecb0af4f7b6e08640bfa34
push id105996
push userbmo:ato@sny.no
push dateWed, 11 Apr 2018 12:15:00 +0000 (2018-04-11)
reviewersmaja_zf
bugs1452483
milestone61.0a1
Bug 1452483 - Set correct line number for JS evaluation. r?maja_zf Marionette incorrectly sets the JavaScript context line number to 0. The line number is provided to us in in the input, so we should use this. The default fallback if line is not provided is 0 as before. MozReview-Commit-ID: 8gOt9r4awee
testing/marionette/evaluate.js
--- a/testing/marionette/evaluate.js
+++ b/testing/marionette/evaluate.js
@@ -155,17 +155,17 @@ evaluate.sandbox = function(sb, script, 
     }
 
     // timeout and unload handlers
     scriptTimeoutID = setTimeout(timeoutHandler, timeout);
     sb.window.onunload = unloadHandler;
 
     let res;
     try {
-      res = Cu.evalInSandbox(src, sb, "1.8", file, 0);
+      res = Cu.evalInSandbox(src, sb, "1.8", file, line);
     } catch (e) {
       let err = new JavaScriptError(e, {
         fnName: "execute_script",
         file,
         line,
         script,
       });
       reject(err);