Bug 1452479 - Include timeout duration in ScriptTimeoutError. r?maja_zf draft
authorAndreas Tolfsen <ato@sny.no>
Sun, 08 Apr 2018 17:23:14 +0100
changeset 779039 161183b66dd7304541a1759ea50ab8c8078ace9d
parent 779038 cb2bb4a7c1c39a017aa8c24c30b62a5f48922677
push id105636
push userbmo:ato@sny.no
push dateSun, 08 Apr 2018 16:24:58 +0000
reviewersmaja_zf
bugs1452479
milestone61.0a1
Bug 1452479 - Include timeout duration in ScriptTimeoutError. r?maja_zf We don’t currently log what the script timeout was when throwing ScriptTimeoutError. It would provide more value to the user to include the timeout duration than to record "Timed out" as we do currently. MozReview-Commit-ID: 3DM1Xer3Qbz
testing/marionette/evaluate.js
--- a/testing/marionette/evaluate.js
+++ b/testing/marionette/evaluate.js
@@ -109,17 +109,17 @@ evaluate.sandbox = function(sb, script, 
       sandboxName = null,
       timeout = DEFAULT_TIMEOUT,
     } = {}) {
   let scriptTimeoutID, timeoutHandler, unloadHandler;
 
   let promise = new Promise((resolve, reject) => {
     let src = "";
     sb[COMPLETE] = resolve;
-    timeoutHandler = () => reject(new ScriptTimeoutError("Timed out"));
+    timeoutHandler = () => reject(new ScriptTimeoutError(`Timed out after ${timeout} ms`));
     unloadHandler = sandbox.cloneInto(
         () => reject(new JavaScriptError("Document was unloaded")),
         sb);
 
     // wrap in function
     if (!directInject) {
       if (async) {
         sb[CALLBACK] = sb[COMPLETE];