Bug 1451838 - Fix double-mention of exit status. r?whimboo draft
authorAndreas Tolfsen <ato@sny.no>
Fri, 06 Apr 2018 15:28:08 +0100
changeset 778590 17c5bc17187b16ed59a8693de2b010f599392fc9
parent 778495 5bc815b7de6dc7494e3010f823fb79aa351e8fe3
push id105526
push userbmo:ato@sny.no
push dateFri, 06 Apr 2018 14:30:39 +0000
reviewerswhimboo
bugs1451838
milestone61.0a1
Bug 1451838 - Fix double-mention of exit status. r?whimboo The Display trait implementation for ExitStatus returns "exit code: 0", leading to a convoluted sentence such as "Browser process stopped with exit status exit code: 0". MozReview-Commit-ID: 2D1JsFIhF7d
testing/geckodriver/src/marionette.rs
--- a/testing/geckodriver/src/marionette.rs
+++ b/testing/geckodriver/src/marionette.rs
@@ -596,17 +596,17 @@ impl WebDriverHandler<GeckoExtensionRout
                 conn.close();
             }
         }
 
         if let Some(ref mut runner) = self.browser {
             // TODO(https://bugzil.la/1443922):
             // Use toolkit.asyncshutdown.crash_timout pref
             match runner.wait(time::Duration::from_secs(70)) {
-                Ok(x) => debug!("Browser process stopped with exit status {}", x),
+                Ok(x) => debug!("Browser process stopped: {}", x),
                 Err(e) => error!("Failed to stop browser process: {}", e),
             }
         }
 
         self.connection = Mutex::new(None);
         self.browser = None;
     }
 }