Bug 1449187 - Whitelist extra autocomplete reflows that happen due to a default bookmark with a long URL on beta/release. r?mconley draft
authorMark Banner <standard8@mozilla.com>
Fri, 06 Apr 2018 15:17:19 +0100
changeset 778615 d934d6ae5275b3bd00c96e25e3456cd977b8e9e9
parent 778495 5bc815b7de6dc7494e3010f823fb79aa351e8fe3
push id105534
push userbmo:standard8@mozilla.com
push dateFri, 06 Apr 2018 14:48:13 +0000
reviewersmconley
bugs1449187
milestone61.0a1
Bug 1449187 - Whitelist extra autocomplete reflows that happen due to a default bookmark with a long URL on beta/release. r?mconley MozReview-Commit-ID: 30RgB1BAtL1
browser/base/content/test/performance/browser_urlbar_keyed_search.js
--- a/browser/base/content/test/performance/browser_urlbar_keyed_search.js
+++ b/browser/base/content/test/performance/browser_urlbar_keyed_search.js
@@ -78,16 +78,47 @@ const EXPECTED_REFLOWS_FIRST_OPEN = [
       "_openAutocompletePopup@chrome://browser/content/urlbarBindings.xml",
       "openAutocompletePopup@chrome://browser/content/urlbarBindings.xml",
       "openPopup@chrome://global/content/bindings/autocomplete.xml",
       "set_popupOpen@chrome://global/content/bindings/autocomplete.xml",
     ],
   },
 ];
 
+// These extra reflows happen on beta/release as one of the default bookmarks in
+// bookmarks.html.in has a long URL.
+if (AppConstants.RELEASE_OR_BETA) {
+  EXPECTED_REFLOWS_FIRST_OPEN.push({
+    stack: [
+      "_handleOverflow@chrome://global/content/bindings/autocomplete.xml",
+      "_onUnderflow@chrome://global/content/bindings/autocomplete.xml",
+      "onunderflow@chrome://browser/content/browser.xul",
+    ],
+    maxCount: 6,
+  });
+  EXPECTED_REFLOWS_FIRST_OPEN.push({
+    stack: [
+      "_handleOverflow@chrome://global/content/bindings/autocomplete.xml",
+      "_onOverflow@chrome://global/content/bindings/autocomplete.xml",
+      "onoverflow@chrome://browser/content/browser.xul",
+    ],
+    maxCount: 6,
+  });
+  EXPECTED_REFLOWS_FIRST_OPEN.push({
+    stack: [
+      "_handleOverflow@chrome://global/content/bindings/autocomplete.xml",
+      "_adjustAcItem@chrome://global/content/bindings/autocomplete.xml",
+      "_appendCurrentResult@chrome://global/content/bindings/autocomplete.xml",
+      "_invalidate@chrome://global/content/bindings/autocomplete.xml",
+      "invalidate@chrome://global/content/bindings/autocomplete.xml",
+    ],
+    maxCount: 12,
+  });
+}
+
 /**
  * Returns a Promise that resolves once the AwesomeBar popup for a particular
  * window has appeared after having done a search for its input text.
  *
  * @param win (browser window)
  *        The window to do the search in.
  * @returns Promise
  */