bug 1451750 - treat rrsets from different resolvers as different r?mcmanus
... even if all the addresses are identical.
Otherwise the IsTRR() bit would be dropped, resulting in
about:networking showing false for this entry while in reality being
TRR. Or vice versa.
MozReview-Commit-ID: JABLm09iCnn
--- a/netwerk/dns/nsHostResolver.cpp
+++ b/netwerk/dns/nsHostResolver.cpp
@@ -1432,16 +1432,20 @@ different_rrset(AddrInfo *rrset1, AddrIn
if (!rrset1 || !rrset2) {
return true;
}
LOG(("different_rrset %s\n", rrset1->mHostName));
nsTArray<NetAddr> orderedSet1;
nsTArray<NetAddr> orderedSet2;
+ if (rrset1->IsTRR() != rrset2->IsTRR()) {
+ return true;
+ }
+
for (NetAddrElement *element = rrset1->mAddresses.getFirst();
element; element = element->getNext()) {
if (LOG_ENABLED()) {
char buf[128];
NetAddrToString(&element->mAddress, buf, 128);
LOG(("different_rrset add to set 1 %s\n", buf));
}
orderedSet1.InsertElementAt(orderedSet1.Length(), element->mAddress);