Bug 1451319 - Unset MINIDUMP_SAVE_PATH for mozcrash unit tests.
The build job on Windows sets the MINIDUMP_SAVE_PATH env variable,
and because it isn't unset mozcrash copies all created minidump
files from unittests to the "public/build" folder, which then
get uploaded as artifacts.
MozReview-Commit-ID: 6JNnRZGlOj3
--- a/testing/mozbase/mozcrash/tests/conftest.py
+++ b/testing/mozbase/mozcrash/tests/conftest.py
@@ -12,17 +12,18 @@ import mozcrash
def stackwalk(tmpdir_factory):
stackwalk = tmpdir_factory.mktemp('stackwalk_binary').join('stackwalk')
stackwalk.write('fake binary')
stackwalk.chmod(0o744)
return stackwalk
@pytest.fixture
-def check_for_crashes(tmpdir, stackwalk):
+def check_for_crashes(tmpdir, stackwalk, monkeypatch):
+ monkeypatch.delenv('MINIDUMP_SAVE_PATH', raising=False)
def wrapper(dump_directory=fspath(tmpdir),
symbols_path='symbols_path',
stackwalk_binary=fspath(stackwalk),
dump_save_path=None,
test_name=None,
quiet=True):
return mozcrash.check_for_crashes(dump_directory,