Bug 1328273 - Log mozrunner.utils failure messages at the error level, r=jgraham draft
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Wed, 04 Apr 2018 16:46:32 -0400
changeset 777510 b9eef524597a29cfa912fb14c5eab0d58f74d430
parent 777437 c23c7481957f7b982cffc0ce1d25979c69ca2c2f
push id105231
push userahalberstadt@mozilla.com
push dateWed, 04 Apr 2018 21:37:17 +0000
reviewersjgraham
bugs1328273
milestone61.0a1
Bug 1328273 - Log mozrunner.utils failure messages at the error level, r=jgraham MozReview-Commit-ID: LSzpGJeyY77
testing/mozbase/mozrunner/mozrunner/utils.py
--- a/testing/mozbase/mozrunner/mozrunner/utils.py
+++ b/testing/mozbase/mozrunner/mozrunner/utils.py
@@ -152,18 +152,18 @@ def test_environment(xrePath, env=None, 
             llvmsym = os.path.join(
                 llvmSymbolizerDir,
                 "llvm-symbolizer" + mozinfo.info["bin_suffix"].encode('ascii'))
             if os.path.isfile(llvmsym):
                 env["ASAN_SYMBOLIZER_PATH"] = llvmsym
                 log.info("INFO | runtests.py | ASan using symbolizer at %s"
                          % llvmsym)
             else:
-                log.info("TEST-UNEXPECTED-FAIL | runtests.py | Failed to find"
-                         " ASan symbolizer at %s" % llvmsym)
+                log.error("TEST-UNEXPECTED-FAIL | runtests.py | Failed to find"
+                          " ASan symbolizer at %s" % llvmsym)
 
             # Returns total system memory in kilobytes.
             if mozinfo.isWin:
                 totalMemory = int(
                     os.popen("wmic computersystem get TotalPhysicalMemory").readlines()[1]) / 1024
             elif mozinfo.isMac:
                 totalMemory = int(os.popen("sysctl hw.memsize").readlines()[0].split()[1]) / 1024
             else:
@@ -213,18 +213,18 @@ def test_environment(xrePath, env=None, 
     if tsan and mozinfo.isLinux:
         # Symbolizer support.
         llvmsym = os.path.join(xrePath, "llvm-symbolizer")
         if os.path.isfile(llvmsym):
             env["TSAN_OPTIONS"] = "external_symbolizer_path=%s" % llvmsym
             log.info("INFO | runtests.py | TSan using symbolizer at %s"
                      % llvmsym)
         else:
-            log.info("TEST-UNEXPECTED-FAIL | runtests.py | Failed to find TSan"
-                     " symbolizer at %s" % llvmsym)
+            log.error("TEST-UNEXPECTED-FAIL | runtests.py | Failed to find TSan"
+                      " symbolizer at %s" % llvmsym)
 
     ubsan = bool(mozinfo.info.get("ubsan"))
     if ubsan and (mozinfo.isLinux or mozinfo.isMac):
         if ubsanPath:
             log.info("UBSan enabled.")
             ubsanOptions = []
             suppressionsFile = os.path.join(
                 ubsanPath, 'ubsan_suppressions.txt')