Bug 1451400: Avoid extending xul:button in the dropmarker bindings. r?dao
Similarly to toolbarpaletteitem, this only seems relevant to avoid clicking in
the icon from capturing the event.
I didn't see any other rendering difference on the dropmarkers I know (the
history one, and the ones in buttons), but I could only test Linux so I'd
appreciate a sanity-check on other OSes.
I used inline style because I wasn't really enthusiastic about repeating the
same rule three times in dropmarker.css instead.
MozReview-Commit-ID: 29lOvtjeBgM
--- a/toolkit/content/widgets/general.xml
+++ b/toolkit/content/widgets/general.xml
@@ -108,19 +108,19 @@
this.selectedIndex = selectedIndex;
return val;
]]>
</setter>
</property>
</implementation>
</binding>
- <binding id="dropmarker" extends="xul:button">
+ <binding id="dropmarker">
<resources>
<stylesheet src="chrome://global/skin/dropmarker.css"/>
</resources>
<content>
- <xul:image class="dropmarker-icon"/>
+ <xul:image class="dropmarker-icon" style="pointer-events: none" />
</content>
</binding>
</bindings>